Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto Runtime.stop() #38

Merged
merged 8 commits into from
Nov 16, 2021
Merged

Add auto Runtime.stop() #38

merged 8 commits into from
Nov 16, 2021

Conversation

mgkwill
Copy link
Contributor

@mgkwill mgkwill commented Nov 11, 2021

No description provided.

@mgkwill
Add auto Runtime.stop()
57305d6 
Signed-off-by: Marcus G K Williams <[email protected]>
@mgkwill mgkwill linked an issue Nov 11, 2021 that may be closed by this pull request
Need to call Runtime.stop() automatically #34
Closed
@mgkwill mgkwill self-assigned this Nov 11, 2021
@mgkwill mgkwill added 1-feature New feature request area: magma/core Issues with something in lava/magma/core area: magma/runtime Issues with something in lava/magma/runtime labels Nov 11, 2021
awintel
awintel approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@awintel awintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle all good, just some minor docstring suggestions.
Thanks!

src/lava/magma/core/process/process.py Outdated Show resolved Hide resolved
src/lava/magma/runtime/runtime.py Outdated Show resolved Hide resolved
mgkwill
mgkwill commented Nov 11, 2021
View reviewed changes
Copy link
Contributor Author

@mgkwill mgkwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@jlakness-intel @PhilippPlank care to review?

@mgkwill mgkwill removed the request for review from PhilippPlank November 11, 2021 22:27
@mgkwill mgkwill removed the request for review from jlakness November 16, 2021 18:07
@PhilippPlank PhilippPlank self-requested a review November 16, 2021 21:32
PhilippPlank
PhilippPlank approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@PhilippPlank PhilippPlank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me.

@mgkwill mgkwill merged commit 2b8fe00 into lava-nc:main Nov 16, 2021
@mgkwill mgkwill deleted the auto_stop branch November 16, 2021 23:03
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@mgkwill @PhilippPlank
Add auto Runtime.stop() (lava-nc#38)
d223d62 
* Add auto Runtime.stop()

Signed-off-by: Marcus G K Williams <[email protected]>

* Update process.py change __del__ docstring

* Update runtime.py change docstring

* Update runtime.py fix __del__ docstring

Co-authored-by: PhilippPlank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippPlank PhilippPlank PhilippPlank approved these changes

@awintel awintel awintel approved these changes

Assignees

@mgkwill mgkwill

Labels
1-feature New feature request area: magma/core Issues with something in lava/magma/core area: magma/runtime Issues with something in lava/magma/runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to call Runtime.stop() automatically
3 participants
@mgkwill @PhilippPlank @awintel