Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose noise amplitude for SCIF #383

Merged
merged 6 commits into from
Sep 27, 2022
Merged

Expose noise amplitude for SCIF #383

merged 6 commits into from
Sep 27, 2022

Conversation

GaboFGuerra
Copy link
Contributor

Issue Number:

Objective of pull request: Expose noise_amplitude at the process level for SCIF neurons.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@GaboFGuerra GaboFGuerra changed the title With req pause Expose noise amplitude for SCIF Sep 27, 2022
awintel
awintel approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@awintel awintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You might want to use a non-arbitrary default later and introduce proper class docstrings. But not critical right now.

src/lava/proc/scif/process.py Show resolved Hide resolved
srrisbud
srrisbud approved these changes Sep 27, 2022
View reviewed changes
src/lava/proc/scif/process.py Show resolved Hide resolved
@GaboFGuerra GaboFGuerra merged commit ccf271a into lava-nc:main Sep 27, 2022
mgkwill pushed a commit that referenced this pull request Sep 28, 2022
@GaboFGuerra
Expose noise amplitude for SCIF (#383)
0f9b1a8 
* Enable exception proc_map, working with dataclasses, etc.

Signed-off-by: GaboFGuerra <[email protected]>

* Integrate YS's changes to enable req_pause.

Signed-off-by: GaboFGuerra <[email protected]>

* Expose noise amplitude at the process level for SCIF.

Signed-off-by: GaboFGuerra <[email protected]>

* Remove prints from req_pause debug.

Signed-off-by: GaboFGuerra <[email protected]>

* Solve lint issue.

Signed-off-by: GaboFGuerra <[email protected]>
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@GaboFGuerra
Expose noise amplitude for SCIF (lava-nc#383)
756e637 
* Enable exception proc_map, working with dataclasses, etc.

Signed-off-by: GaboFGuerra <[email protected]>

* Integrate YS's changes to enable req_pause.

Signed-off-by: GaboFGuerra <[email protected]>

* Expose noise amplitude at the process level for SCIF.

Signed-off-by: GaboFGuerra <[email protected]>

* Remove prints from req_pause debug.

Signed-off-by: GaboFGuerra <[email protected]>

* Solve lint issue.

Signed-off-by: GaboFGuerra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srrisbud srrisbud srrisbud approved these changes

@awintel awintel awintel approved these changes

@joyeshmishra joyeshmishra Awaiting requested review from joyeshmishra

@ysingh7 ysingh7 Awaiting requested review from ysingh7

@bamsumit bamsumit Awaiting requested review from bamsumit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GaboFGuerra @srrisbud @awintel