Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output messages for ReadGate's send_req_pause port. #385

Merged
merged 10 commits into from
Sep 28, 2022

Conversation

GaboFGuerra
Copy link
Contributor

Issue Number:

Objective of pull request: Add output messages for ReadGate's send_req_pause port.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@ysingh7 ysingh7 self-requested a review September 28, 2022 00:17
@GaboFGuerra GaboFGuerra merged commit 5b363da into lava-nc:main Sep 28, 2022
mgkwill pushed a commit that referenced this pull request Sep 28, 2022
* Enable exception proc_map, working with dataclasses, etc.

Signed-off-by: GaboFGuerra <[email protected]>

* Integrate YS's changes to enable req_pause.

Signed-off-by: GaboFGuerra <[email protected]>

* Expose noise amplitude at the process level for SCIF.

Signed-off-by: GaboFGuerra <[email protected]>

* Remove prints from req_pause debug.

Signed-off-by: GaboFGuerra <[email protected]>

* Update ReadGate API.

Signed-off-by: GaboFGuerra <[email protected]>

* Update API on the Python model.

Signed-off-by: GaboFGuerra <[email protected]>

* Solve lint issue.

* Add req_pause messaging to read_gate.

Signed-off-by: GaboFGuerra <[email protected]>

Signed-off-by: GaboFGuerra <[email protected]>
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* Enable exception proc_map, working with dataclasses, etc.

Signed-off-by: GaboFGuerra <[email protected]>

* Integrate YS's changes to enable req_pause.

Signed-off-by: GaboFGuerra <[email protected]>

* Expose noise amplitude at the process level for SCIF.

Signed-off-by: GaboFGuerra <[email protected]>

* Remove prints from req_pause debug.

Signed-off-by: GaboFGuerra <[email protected]>

* Update ReadGate API.

Signed-off-by: GaboFGuerra <[email protected]>

* Update API on the Python model.

Signed-off-by: GaboFGuerra <[email protected]>

* Solve lint issue.

* Add req_pause messaging to read_gate.

Signed-off-by: GaboFGuerra <[email protected]>

Signed-off-by: GaboFGuerra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants