-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add output messages for ReadGate's send_req_pause port. #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GaboFGuerra <[email protected]>
Signed-off-by: GaboFGuerra <[email protected]>
Signed-off-by: GaboFGuerra <[email protected]>
Signed-off-by: GaboFGuerra <[email protected]>
Signed-off-by: GaboFGuerra <[email protected]>
Signed-off-by: GaboFGuerra <[email protected]>
Signed-off-by: GaboFGuerra <[email protected]>
Signed-off-by: GaboFGuerra <[email protected]>
mgkwill
approved these changes
Sep 28, 2022
bamsumit
approved these changes
Sep 28, 2022
mgkwill
pushed a commit
that referenced
this pull request
Sep 28, 2022
* Enable exception proc_map, working with dataclasses, etc. Signed-off-by: GaboFGuerra <[email protected]> * Integrate YS's changes to enable req_pause. Signed-off-by: GaboFGuerra <[email protected]> * Expose noise amplitude at the process level for SCIF. Signed-off-by: GaboFGuerra <[email protected]> * Remove prints from req_pause debug. Signed-off-by: GaboFGuerra <[email protected]> * Update ReadGate API. Signed-off-by: GaboFGuerra <[email protected]> * Update API on the Python model. Signed-off-by: GaboFGuerra <[email protected]> * Solve lint issue. * Add req_pause messaging to read_gate. Signed-off-by: GaboFGuerra <[email protected]> Signed-off-by: GaboFGuerra <[email protected]>
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* Enable exception proc_map, working with dataclasses, etc. Signed-off-by: GaboFGuerra <[email protected]> * Integrate YS's changes to enable req_pause. Signed-off-by: GaboFGuerra <[email protected]> * Expose noise amplitude at the process level for SCIF. Signed-off-by: GaboFGuerra <[email protected]> * Remove prints from req_pause debug. Signed-off-by: GaboFGuerra <[email protected]> * Update ReadGate API. Signed-off-by: GaboFGuerra <[email protected]> * Update API on the Python model. Signed-off-by: GaboFGuerra <[email protected]> * Solve lint issue. * Add req_pause messaging to read_gate. Signed-off-by: GaboFGuerra <[email protected]> Signed-off-by: GaboFGuerra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Objective of pull request: Add output messages for ReadGate's send_req_pause port.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information