Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed point (bit-accurate with Loihi) and floating point ProcessModels for LIF process #39

Closed
wants to merge 12 commits into from
Closed

Fixed point (bit-accurate with Loihi) and floating point ProcessModels for LIF process #39

wants to merge 12 commits into from

Conversation

srrisbud
Copy link
Contributor

The fixed point ProcessModel, which is bit-accurate with Loihi, is leanest ProcessModel of such behaviour. Features like axonal delay, refractory period, etc. are not supported.

@srrisbud srrisbud added 0-needs-review For all new issues area: proc Issues with something in lava/proc lif area: magma/core Issues with something in lava/magma/core labels Nov 11, 2021
@srrisbud srrisbud self-assigned this Nov 11, 2021
@srrisbud srrisbud linked an issue Nov 11, 2021 that may be closed by this pull request
Create fixed point ProcessModel for LIF, bit-accurate with Loihi hardware implementation #40
Closed
awintel
awintel requested changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@awintel awintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but a few things require changes if there's still time or filing of separate issues.

lava/magma/compiler/builder.py Show resolved Hide resolved
lava/magma/core/decorator.py Show resolved Hide resolved
lava/magma/core/decorator.py Show resolved Hide resolved
lava/magma/core/decorator.py Show resolved Hide resolved
lava/proc/lif/models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_process.py Outdated Show resolved Hide resolved
drager-intel
drager-intel requested changes Nov 12, 2021
View reviewed changes
lava/proc/lif/models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
tests/proc/lif/test_models.py Outdated Show resolved Hide resolved
@srrisbud
Minor change to variable builder to support floating point variables …
a78da05 
…created through LavaPyType

Signed-off-by: Risbud, Sumedh <[email protected]>
@srrisbud
Merge branch 'bit_acc_lif_dense' into main
24c4615
@srrisbud
lava -> src/lava: reorg to resolve merge conflicts
c9dd001 
Signed-off-by: Risbud, Sumedh <[email protected]>
@srrisbud
tests -> tests/lava: reorg to resolve merge conflicts
fdbeb73 
Signed-off-by: Risbud, Sumedh <[email protected]>
@srrisbud
tests -> tests/lava: reorg to resolve merge conflicts
054a4a9 
Signed-off-by: Risbud, Sumedh <[email protected]>
@srrisbud
Merge branch 'main' of https://github.com/srrisbud/lava into main
8a4c19f
@srrisbud
Manual merge of changes from message passing refactoring (after lava-…
2c57277 
…>src/lava reorg)

Signed-off-by: Risbud, Sumedh <[email protected]>
@srrisbud srrisbud closed this Nov 13, 2021
@srrisbud srrisbud removed a link to an issue Nov 18, 2021
Create fixed point ProcessModel for LIF, bit-accurate with Loihi hardware implementation #40
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awintel awintel awintel requested changes

@drager-intel drager-intel drager-intel requested changes

@mgkwill mgkwill Awaiting requested review from mgkwill

Assignees

@srrisbud srrisbud

Labels
0-needs-review For all new issues area: magma/core Issues with something in lava/magma/core area: proc Issues with something in lava/proc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srrisbud @awintel @drager-intel