Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a bug in network compilation and multiple port polling #391

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Fixes a bug in network compilation and multiple port polling #391

merged 1 commit into from
Sep 30, 2022

Conversation

joyeshmishra
Copy link
Contributor

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

mathisrichter
mathisrichter approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@mathisrichter mathisrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the changes but I checked that the two tests we wrote are now unblocked.
Great job guys! :)

@joyeshmishra joyeshmishra merged commit 1e55779 into main Sep 30, 2022
@joyeshmishra joyeshmishra deleted the misc_bug_fixes branch September 30, 2022 00:04
@tim-shea tim-shea added this to the Release 0.5.1 milestone Oct 25, 2022
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@joyeshmishra
Fixes a bug in network compilation and multiple port polling (lava-nc…
5cf38f0 
…#391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srrisbud srrisbud srrisbud approved these changes

@mathisrichter mathisrichter mathisrichter approved these changes

@ysingh7 ysingh7 Awaiting requested review from ysingh7

@bamsumit bamsumit Awaiting requested review from bamsumit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@joyeshmishra @mathisrichter @srrisbud @tim-shea