Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of LIF reset models in CPU backend #415

Merged
merged 41 commits into from
Oct 14, 2022
Merged

Implementation of LIF reset models in CPU backend #415

merged 41 commits into from
Oct 14, 2022

Conversation

bamsumit
Copy link
Contributor

Issue Number: 414

Objective of pull request:
Implement python model for LIFReset process.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

bamsumit and others added 29 commits March 8, 2022 10:23
@bamsumit
update refport unittest to always wait when it writes to port for con…
141e732 
…sistent behavior

Signed-off-by: bamsumit <[email protected]>
@bamsumit
Removed pyproject changes
7097dd8 
Signed-off-by: bamsumit <[email protected]>
@bamsumit
Merge branch 'lava-nc:main' into main
5234c1b
@bamsumit
Merge branch 'lava-nc:main' into main
2644255
@bamsumit
Merge branch 'lava-nc:main' into main
a3116bb
@bamsumit
Merge branch 'lava-nc:main' into main
31715fc
@bamsumit
Merge branch 'main' of github.com:lava-nc/lava into main
f90595d
@bamsumit
Merge branch 'main' of github.com:bamsumit/lava into main
c988ad8
@bamsumit
Merge branch 'lava-nc:main' into main
be2ba52
@bamsumit
Fix to convolution tests. Fixed imcompatible mnist_pretrained for old…
1fb7353 
… python versions.

Signed-off-by: bamsumit <[email protected]>
@bamsumit
merged with upstream
4a58d97 
Signed-off-by: bamsumit <[email protected]>
@bamsumit
Merge branch 'main' of github.com:lava-nc/lava into main
d4636c3
@bamsumit
Missing moudle parent fix
68c817c 
Signed-off-by: bamsumit <[email protected]>
@bamsumit
Merge branch 'main' of github.com:lava-nc/lava into main
1b59e58
@bamsumit
Merge branch 'main' of github.com:lava-nc/lava into main
9099529
@bamsumit
Merge branch 'main' of github.com:lava-nc/lava into main
fd5b813
@joyeshmishra
Added ConvVarModel
fd2163c
@bamsumit
Merge branch 'main' of github.com:lava-nc/lava into main
2fb345c
@bamsumit
Merge branch 'conv_manager' of github.com:lava-nc/lava into main
8e73642
@bamsumit
Merge branch 'main' of github.com:lava-nc/lava into main
c441098
@bamsumit
Merge branch 'main' into main
964c5ca
@bamsumit
Merged with lava-nc main
8b2e8a2 
Signed-off-by: bamsumit <[email protected]>
@bamsumit
Merge branch 'main' of github.com:bamsumit/lava into main
4431f61
@bamsumit
Merge branch 'main' of github.com:lava-nc/lava into main
7e154fc
@bamsumit
Merge branch 'main' of github.com:lava-nc/lava into main
c5b5509
@bamsumit
Merge branch 'main' of github.com:lava-nc/lava into main
2241e23
@bamsumit
Merge branch 'main' of github.com:lava-nc/lava into main
95545a2
@bamsumit
LIF reset python model implementation
83c5a6c 
Signed-off-by: bamsumit <[email protected]>
@bamsumit
Merge branch 'main' into lif_reset
7b2c726
@bamsumit bamsumit linked an issue Oct 13, 2022 that may be closed by this pull request
LIFReset process has no python model #414
Closed
10 tasks
tim-shea
tim-shea approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@tim-shea tim-shea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/lava/proc/lif/models.py Show resolved Hide resolved
src/lava/proc/lif/models.py Show resolved Hide resolved
@PhilippPlank
Update ci-build.yml
2388636 
try fix poetry issue on windows
@PhilippPlank
Update ci-build.yml
57e813f 
try fix windows fail
@PhilippPlank
Update ci-build.yml
42c9356 
try fix windows failure
@PhilippPlank
Update ci-build.yml
4412573 
try fix windows failure
@PhilippPlank
Update ci-build.yml
d9c47ec 
try fix windows failure
@PhilippPlank
Update ci-build.yml
4e727bb 
try fix windows failure
@PhilippPlank
Update ci-build.yml
cc54299 
try fix windows failure
@PhilippPlank
Update ci-build.yml
47e1fb7 
try fix windows failure
@PhilippPlank
Update ci-build.yml
db49294 
try fix windows failure
@PhilippPlank
Update ci-build.yml
550fbf9 
try fix windows failure
@PhilippPlank
Update ci-build.yml
9ab2bbd 
try fix windows failure
@PhilippPlank
Update ci-build.yml
c4eb67a 
try fix poetry issues
@PhilippPlank PhilippPlank merged commit 51b3334 into lava-nc:main Oct 14, 2022
@tim-shea tim-shea added this to the Release 0.5.1 milestone Oct 25, 2022
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@bamsumit @joyeshmishra @PhilippPlank
Implementation of LIF reset models in CPU backend (lava-nc#415)
05bf54c 
* update refport unittest to always wait when it writes to port for consistent behavior

Signed-off-by: bamsumit <[email protected]>

* Removed pyproject changes

Signed-off-by: bamsumit <[email protected]>

* Fix to convolution tests. Fixed imcompatible mnist_pretrained for old python versions.

Signed-off-by: bamsumit <[email protected]>

* Missing moudle parent fix

Signed-off-by: bamsumit <[email protected]>

* Added ConvVarModel

* LIF reset python model implementation

Signed-off-by: bamsumit <[email protected]>

* Update ci-build.yml

try fix poetry issues

Signed-off-by: bamsumit <[email protected]>
Co-authored-by: Joyesh Mishra <[email protected]>
Co-authored-by: PhilippPlank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippPlank PhilippPlank PhilippPlank approved these changes

@tim-shea tim-shea tim-shea approved these changes

@srrisbud srrisbud Awaiting requested review from srrisbud

@mathisrichter mathisrichter Awaiting requested review from mathisrichter

@mgkwill mgkwill Awaiting requested review from mgkwill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.5.1
Development

Successfully merging this pull request may close these issues.

LIFReset process has no python model
4 participants
@bamsumit @tim-shea @PhilippPlank @joyeshmishra