-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler graph: Enable model selection, fixing warning in QUBO tutorial #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phstratmann
requested review from
mathisrichter,
srrisbud,
bamsumit,
PhilippPlank and
GaboFGuerra
October 14, 2022 11:20
PhilippPlank
approved these changes
Oct 14, 2022
GaboFGuerra
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
try fix failing unit test by specifying select_tag="floating_pt"
mathisrichter
added a commit
to mathisrichter/lava
that referenced
this pull request
Oct 14, 2022
…O tutorial (lava-nc#418)" This reverts commit bafca33.
16 tasks
bamsumit
pushed a commit
that referenced
this pull request
Oct 20, 2022
…O tutorial (#418)" (#419) This reverts commit bafca33. Co-authored-by: Philipp Stratmann <[email protected]>
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
…al (lava-nc#418) * fixed model selection * minor lintin * Update test_models.py try fix failing unit test by specifying select_tag="floating_pt" * corrected ipykernel in jupyter notebook Co-authored-by: PhilippPlank <[email protected]>
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
…O tutorial (lava-nc#418)" (lava-nc#419) This reverts commit 4617211. Co-authored-by: Philipp Stratmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: 417 (& 56 in lava-optimization)
Objective of pull request:
As the compiler graph scans through all modules in the path, it checks if either of the encountered class is a ProcModel.
If a file imports a module, like in solver.py of lava-optimization,
from lava.lib.optimization.solvers.generic.sub_process_models import StochasticIntegrateAndFireModel
the crawler will try to import that module as well. This leads to a warning, as the compiler graph incorrectly assumes that the found StochasticIntegrateAndFireModel is in solver.py.
The correct behavior should be that the crawler goes through all modules, and only selects Models implemented in the specific module, not those that are only imported.
The important change is in compiler_graphs.py.
Unfortunately, this change broke four unit tests, three in test_monitors, one in test_tutorial. This was due to the fact that the new crawler chooses the bitacc LifProcModel by default. Accordingly, I now specifically select the floating_pt model where tests would break otherwise.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Please check your PR type: