Add Profiler base class #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamsumit
approved these changes
Oct 25, 2022
tim-shea
reviewed
Oct 25, 2022
tim-shea
reviewed
Oct 25, 2022
tim-shea
approved these changes
Oct 25, 2022
| from lava.magma.core.run_configs import RunConfig, Loihi2HwCfg | ||
|
|
||
| # Dictionary to relate a certain RunCfg to specific Profiler | ||
| run_cfg_dict: ty.Dict[RunConfig, RunConfig] = {} |
There was a problem hiding this comment.
Should this maybe go into the Profiler class?
There was a problem hiding this comment.
It was, but this dict needs to be filled based on available imports. The current solution can probably be improved, but it fits with our current style to try importing loihi specific modules.
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* Update profiler.py * Update profiler.py * Update profiler.py * Update profiler.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective of pull request: Adding a profiler base class which selects an appropriate Profiler based on the chosen RunCfg. Currently only the Loihi2HWProfiler for profiling Loihi 2 will be available, if lava-loihi is also installed (INRC members only). In the future this class can choose profiler implementations for Loihi 1, Loihi 2, CPU, GPU or other neuromorphic hardware.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information