Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated networkx from 2.8 to 2.8.7. #453

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Updated networkx from 2.8 to 2.8.7. #453

merged 3 commits into from
Oct 28, 2022

Conversation

a-t-0
Copy link
Contributor

@a-t-0 a-t-0 commented Oct 28, 2022

Issue Number: #452

Objective of pull request: Fix error '_AxesStack' object is not callable when plotting some networkx graphs of a lava SNN, as described here.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • Error: '_AxesStack' object is not callable is thrown in some cases when plotting a networkx graph using lava.

What is the new behavior?

  • No error is thrown when plotting a networkx graph using lava.

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Objective is reached by updating the networkx dependency from 2.8 to 2.8.7.

@a-t-0 a-t-0 mentioned this pull request Oct 28, 2022
10 tasks
@mgkwill
Copy link
Contributor

mgkwill commented Oct 28, 2022

We are testing this with our internal plugin and will merge once that test is complete.

@mgkwill mgkwill merged commit 4b9f149 into lava-nc:main Oct 28, 2022
@PhilippPlank PhilippPlank linked an issue Nov 21, 2022 that may be closed by this pull request
10 tasks
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* Updated networkx from 2.8 to 2.8.7.

* Included sha256: to correct copy paste error.

Co-authored-by: Your Name <[email protected]>
Co-authored-by: PhilippPlank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'_AxesStack' object is not callable
3 participants