Graded spike payload in pre-synaptic trace updates - floating-pt and bit-approximate-loihi
#607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 2, 2023 13:08
gkarray
requested review from
weidel-p,
mathisrichter,
awintel,
elvinhajizada and
PhilippPlank
Closed
4 tasks
…nc/lava into dev/learning_graded_spikes
There was a problem hiding this comment.
I have not reviewed this to a point, where I could approve or block it, so I am just leaving comments.
It all looks good though, at least from a high level coding-style point of view. I only added a few minor remarks.
The one thing we could maybe improve are the known-value tests. It is not clear where the known values come from or how we know they are correct. There are also so many that the significance of individual numbers is unclear. Please keep in mind that someone will at some point look at this code and need to understand why all these values as deemed correct. Make sure that it is very easy to understand that from the code. That person could be yourself one year from now. :)
PhilippPlank
approved these changes
Feb 15, 2023
…nc/lava into dev/learning_graded_spikes
…pikes # Conflicts: # src/lava/magma/core/model/py/connection.py
mathisrichter
approved these changes
Feb 17, 2023
…nc/lava into dev/learning_graded_spikes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #606
Objective of pull request: As a user of the learning API, I would like to use graded spike payloads to update pre-synaptic traces in order to implement more complex learning algorithms. Especially, this is critical for prototype-based learning approaches.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information