Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug in README.md example code #61

Merged
merged 4 commits into from
Nov 22, 2021
Merged

Fixed bug in README.md example code #61

merged 4 commits into from
Nov 22, 2021

Conversation

mathisrichter
Copy link
Contributor

Creating connections was using self.dense even though the variable dense was local.

@mathisrichter
Fixed bug in README.md example code
01f12ec 
Creating connections was using `self.dense` even though the variable `dense` was local.
@mathisrichter mathisrichter added 1-bug Something isn't working documentation Improvements or additions to documentation 0-needs-review For all new issues labels Nov 16, 2021
@mathisrichter mathisrichter linked an issue Nov 16, 2021 that may be closed by this pull request
README.md example code uses wrong variables #62
Closed
awintel
awintel approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@awintel awintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.

PhilippPlank
PhilippPlank approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@PhilippPlank PhilippPlank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@mgkwill mgkwill merged commit 912d0f8 into main Nov 22, 2021
@mgkwill mgkwill deleted the readme_example_code branch July 6, 2022 20:50
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@mathisrichter
Fixed bug in README.md example code (lava-nc#61)
5b0748c 
Creating connections was using `self.dense` even though the variable `dense` was local.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgkwill mgkwill mgkwill approved these changes

@PhilippPlank PhilippPlank PhilippPlank approved these changes

@awintel awintel awintel approved these changes

Assignees
No one assigned
Labels
0-needs-review For all new issues 1-bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README.md example code uses wrong variables
4 participants
@mathisrichter @mgkwill @PhilippPlank @awintel