Enable get/set on learning rule parameters #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeshmishra
approved these changes
Feb 14, 2023
ysingh7
approved these changes
Feb 14, 2023
weidel-p
force-pushed
the
dev/update_learning_rule_sim
branch
from
7a85a19
to
639ccff
Compare
weidel-p
force-pushed
the
dev/update_learning_rule_sim
branch
from
1e92032
to
b2183d1
Compare
weidel-p
force-pushed
the
dev/update_learning_rule_sim
branch
3 times, most recently
from
de7128e
to
59c02d5
Compare
8 tasks
weidel-p
force-pushed
the
dev/update_learning_rule_sim
branch
4 times, most recently
from
e397242
to
2c4c8d5
Compare
gkarray
reviewed
Feb 17, 2023
10 tasks
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* pre-traces and string for floating * y params and tests * tests for fixed pt * minor cleanup * lint * adde lr to initial parameters of LearningDense * rm unused imports * avoid using learning lif * temp: just one stdp test * enable 2f learning rules * revert neuron.py * minor change * lint * clean up str representation of learning rule * cleanup * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
#582 #542
Objective of pull request:
This PR enables to use get/set on parameters of the learning rule.
For that to work, we create Vars in the LearningDense Process and ProcessModel and initialize them with the values given by the learning rule object.
Furthermore, we add a function 'on_var_update' to the
AbstractProcessModelwhich is called when a Var is being updated. This allows us to do further checks and computation if the updated Var leads to changes in the functionality.In order to enable the get/set function for 'dw', 'dt' and 'dd', we had to implement a String LavaType. Strings can be communicated through ports by encoding/decoding them into ASCII.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information