Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License header cleanup #641

Merged
merged 3 commits into from
Feb 22, 2023
Merged

License header cleanup #641

merged 3 commits into from
Feb 22, 2023

Conversation

mathisrichter
Copy link
Contributor

@mathisrichter mathisrichter commented Feb 21, 2023 •
edited by PhilippPlank
Loading

Issue Number:

Objective of pull request: The PR adds license headers where they were missing, fixes some incorrect license headers, and adds an empty line after all license headers for consistency.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@mathisrichter
Cleaned up license headers.
6109ed8 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter
Removed empty modules.
5028f3e 
Signed-off-by: Mathis Richter <[email protected]>
@mathisrichter mathisrichter self-assigned this Feb 21, 2023
@mathisrichter mathisrichter linked an issue Feb 21, 2023 that may be closed by this pull request
Missing and incorrect license headers #640
Closed
@PhilippPlank PhilippPlank merged commit 2c2e8ae into lava-nc:main Feb 22, 2023
@PhilippPlank PhilippPlank added the documentation Improvements or additions to documentation label Feb 22, 2023
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@mathisrichter
License header cleanup (lava-nc#641)
93dd97f 
* Cleaned up license headers.

Signed-off-by: Mathis Richter <[email protected]>

* Removed empty modules.

Signed-off-by: Mathis Richter <[email protected]>

---------

Signed-off-by: Mathis Richter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkarray gkarray gkarray approved these changes

@PhilippPlank PhilippPlank PhilippPlank approved these changes

@weidel-p weidel-p Awaiting requested review from weidel-p

Assignees

@mathisrichter mathisrichter

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing and incorrect license headers
3 participants
@mathisrichter @PhilippPlank @gkarray