Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Pause for Async Process #646

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Fixed Pause for Async Process #646

merged 4 commits into from
Mar 7, 2023

Conversation

ysingh7
Copy link
Contributor

@ysingh7 ysingh7 commented Mar 7, 2023

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@ysingh7 ysingh7 requested a review from srrisbud March 7, 2023 16:11
@ysingh7 ysingh7 merged commit 1be4ea7 into main Mar 7, 2023
@joyeshmishra joyeshmishra linked an issue Mar 7, 2023 that may be closed by this pull request
Runtime throws an error when a pause request is sent after "done" message #513
Closed
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@ysingh7
Fixed Pause for Async Process (lava-nc#646)
5830a6e 
* Fixed Pause for Async Process

* Update model.py

* Modified test to check for pause
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeshmishra joyeshmishra joyeshmishra approved these changes

@bamsumit bamsumit bamsumit approved these changes

@mgkwill mgkwill Awaiting requested review from mgkwill

@srrisbud srrisbud Awaiting requested review from srrisbud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime throws an error when a pause request is sent after "done" message
3 participants
@ysingh7 @joyeshmishra @bamsumit