Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing order of checks when advancing phase in LoihiPyRuntimeService #662

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Changing order of checks when advancing phase in LoihiPyRuntimeService #662

merged 2 commits into from
Apr 17, 2023

Conversation

gkarray
Copy link
Contributor

@gkarray gkarray commented Apr 11, 2023 •
edited
Loading

Issue Number: #659

Objective of pull request: Changing order of checks when advancing phase in LoihiPyRuntimeService.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix

What is the current behavior?

  • When we have 2 Processes with PyLoihiProcessModels, with :
    • Process1 requesting to go from SPK to LRN
    • Process2 requesting to go from SPK to POST_MGMT
  • RuntimeService will orchestrate the following phase transitions within the same time step :
    • SPK -> POST_MGMT -> LRN -> POST_MGMT

What is the new behavior?

  • RuntimeService will orchestrate the following phase transitions within the same time step :
    • SPK -> LRN -> POST_MGMT

Does this introduce a breaking change?

  • No

Supplemental information

@gkarray gkarray self-assigned this Apr 11, 2023
@gkarray gkarray linked an issue Apr 11, 2023 that may be closed by this pull request
SpikeDataloader wrong data fetch sequence: post_guard and run_post_mgmt are running twice when using LearningDense in process graph #659
Closed
@PhilippPlank PhilippPlank added the 1-bug Something isn't working label Apr 11, 2023
weidel-p
weidel-p approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@weidel-p weidel-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real simple solution. Thaks!

@gkarray gkarray merged commit 3bd26b1 into main Apr 17, 2023
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@gkarray
changing order of checks when advancing phase in LoihiPyRuntimeService (
2193f30 
lava-nc#662)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidel-p weidel-p weidel-p approved these changes

@PhilippPlank PhilippPlank PhilippPlank approved these changes

@ysingh7 ysingh7 Awaiting requested review from ysingh7

@mathisrichter mathisrichter Awaiting requested review from mathisrichter

Assignees

@gkarray gkarray

Labels
1-bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@gkarray @weidel-p @PhilippPlank