Fixed automatic append of py_ports and var_ports #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a check to prevent re-appending the same PyPort or VarPort that is already in a process model's py_ports or var_ports list. Adjusted CspRecvPort implementation to allocate numpy _result array once at initialization rather than on every update. Adjusted PyRefPortVectorDense to allocate header numpy arrays the first time they are used, rather than every time a value is sent.
|
Confirmed that this breaks some unit tests in test_learning_rule.py. Needs further investigation. |
It seems that putting the result of the CspRecvPort.recv into a pre-allocated numpy _result leads to a hang due to shared memory between processes, specifically in cases where the user code grabs data from a Monitor. Reverting that change for now, though in the future it would be good to find a way to effectively preallocate to avoid memory allocations during every timestep.
mgkwill
approved these changes
Apr 21, 2023
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* Fixed automatic append of py_ports and var_ports Added a check to prevent re-appending the same PyPort or VarPort that is already in a process model's py_ports or var_ports list. Adjusted CspRecvPort implementation to allocate numpy _result array once at initialization rather than on every update. Adjusted PyRefPortVectorDense to allocate header numpy arrays the first time they are used, rather than every time a value is sent. * Fixing flake formatting. * Reverting change to preallocate _result It seems that putting the result of the CspRecvPort.recv into a pre-allocated numpy _result leads to a hang due to shared memory between processes, specifically in cases where the user code grabs data from a Monitor. Reverting that change for now, though in the future it would be good to find a way to effectively preallocate to avoid memory allocations during every timestep. * Cleanup. * Fixing flake issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to prevent re-appending the same PyPort or VarPort that is already in a process model's py_ports or var_ports list.
Adjusted CspRecvPort implementation to allocate numpy _result array once at initialization rather than on every update.
Adjusted PyRefPortVectorDense to allocate header numpy arrays the first time they are used, rather than every time a value is sent.
Issue Number: #586
Objective of pull request:
Fix incorrect append of py_ports and var_ports on each process model update, resulting in significant slowdown over time when using varports (e.g. Monitor).
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyOne test in test_learning_rule.py seems to be stalling, I don't think this is due to these changes, but will investigate further.
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?