Bugfix to enable monitoring aliased vars #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Required to merge: lava-nc/lava-optimization#217 |
Merged
9 tasks
PhilippPlank
approved these changes
Apr 27, 2023
weidel-p
requested changes
Apr 28, 2023
There was a problem hiding this comment.
This PR adds a suffix to a port name if it already exists which is an easy solution to the problem described in the issue.
I have one request though, could you please add a test which shows that the original issue is solved? So that we can probe aliased vars?
weidel-p
approved these changes
May 2, 2023
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* Bugfix to enable monitoring aliased vars * Update ports.py * Update ports.py * Update test_ports.py * Update test_ports.py * Address review feedback * Match expected behaviour for implicit var port naming --------- Co-authored-by: PhilippPlank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #676
Objective of pull request:
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?