Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncating weights to 0 for Sparse lead to wrong shape fixed #683

Merged
merged 1 commit into from
May 8, 2023

Conversation

weidel-p
Copy link
Contributor

@weidel-p weidel-p commented May 5, 2023

Issue Number:

Objective of pull request:

When initializing Sparse with small but mixed weights, the truncating weights function of the weightutils round them to zero. As those weights are kept in the data field of the sparse matrix, the shape is wrong. This PR fixes this issue by removing these explicit zeros from the sparse matrix.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@PhilippPlank PhilippPlank added the 1-bug Something isn't working label May 5, 2023
@weidel-p weidel-p merged commit 8576c19 into main May 8, 2023
@tim-shea tim-shea added this to the Lava v0.7.1 milestone May 15, 2023
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants