Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor methods without arguments into functions #685

Merged
merged 30 commits into from
Jul 18, 2023
Merged

Refactor methods without arguments into functions #685

merged 30 commits into from
Jul 18, 2023

Commits on May 8, 2023

  1. Refactoring methods without arguments into functions. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 8, 2023
    Configuration menu
    Copy the full SHA
    1cbf330 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Reverting unintentional change to tutorial. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 10, 2023
    Configuration menu
    Copy the full SHA
    e3ea8fd View commit details
    Browse the repository at this point in the history

  2. Added new set of functions by @tim-shea, refactored. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 10, 2023
    Configuration menu
    Copy the full SHA
    b2e48d5 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Fixed linter error: unused import. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 11, 2023
    Configuration menu
    Copy the full SHA
    4d50c28 View commit details
    Browse the repository at this point in the history

  2. Fixed linter and security errors. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 11, 2023
    Configuration menu
    Copy the full SHA
    84fab83 View commit details
    Browse the repository at this point in the history

  3. Fixed linter errors. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 11, 2023
    Configuration menu
    Copy the full SHA
    cf8ca15 View commit details
    Browse the repository at this point in the history

  4. Trying to make nosec work. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 11, 2023
    Configuration menu
    Copy the full SHA
    c9ac3f1 View commit details
    Browse the repository at this point in the history

  5. Moved nosec back; does not seem to make a difference. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 11, 2023
    Configuration menu
    Copy the full SHA
    252cf9c View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Unit tests for some of the new functions in the slurm module. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 12, 2023
    Configuration menu
    Copy the full SHA
    9c10d15 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. Full unit tests for SLURM module. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 13, 2023
    Configuration menu
    Copy the full SHA
    b023a9e View commit details
    Browse the repository at this point in the history

  2. Full unit tests for lava_loihi module. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 13, 2023
    Configuration menu
    Copy the full SHA
    a31bc93 View commit details
    Browse the repository at this point in the history

  3. Deactivated linter error. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 13, 2023
    Configuration menu
    Copy the full SHA
    e2ecf7d View commit details
    Browse the repository at this point in the history

  4. Trying different nosec variants. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 13, 2023
    Configuration menu
    Copy the full SHA
    0572a64 View commit details
    Browse the repository at this point in the history

  5. Trying different nosec variants. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 13, 2023
    Configuration menu
    Copy the full SHA
    1e673de View commit details
    Browse the repository at this point in the history

  6. Trying different nosec variants. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 13, 2023
    Configuration menu
    Copy the full SHA
    57d4bed View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Redesigned the API for lava.utils.{slurm,loihi}. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 18, 2023
    Configuration menu
    Copy the full SHA
    32e71b0 View commit details
    Browse the repository at this point in the history

  2. Another attempt at fixing linting. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 18, 2023
    Configuration menu
    Copy the full SHA
    65746e1 View commit details
    Browse the repository at this point in the history

  3. Trying with noqa 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 18, 2023
    Configuration menu
    Copy the full SHA
    3090ba9 View commit details
    Browse the repository at this point in the history

  4. Fixed module error in test patch 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 18, 2023
    Configuration menu
    Copy the full SHA
    0c75bb4 View commit details
    Browse the repository at this point in the history

  5. Renamed is_lava_loihi_installed to is_installed. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 18, 2023
    Configuration menu
    Copy the full SHA
    b4b6f29 View commit details
    Browse the repository at this point in the history

  6. Fixed code duplication of patch decorators. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 18, 2023
    Configuration menu
    Copy the full SHA
    b212821 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. Added doc string to patch decorator. 

    Signed-off-by: Mathis Richter <[email protected]>
    @mathisrichter
    mathisrichter committed May 20, 2023
    Configuration menu
    Copy the full SHA
    2836465 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/lava-nc/lava into loihi_sys… 

    …tem_refactor
    @mathisrichter
    mathisrichter committed May 20, 2023
    Configuration menu
    Copy the full SHA
    e00f4cd View commit details
    Browse the repository at this point in the history

Commits on May 21, 2023

  1. Merge branch 'main' into loihi_system_refactor

    @mathisrichter
    mathisrichter committed May 21, 2023
    Configuration menu
    Copy the full SHA
    dd8d859 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Merge branch 'main' into loihi_system_refactor

    @mathisrichter
    mathisrichter committed May 22, 2023
    Configuration menu
    Copy the full SHA
    49033e0 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Merge branch 'main' into loihi_system_refactor

    @mathisrichter
    mathisrichter committed May 25, 2023
    Configuration menu
    Copy the full SHA
    e74ba6c View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Merge branch 'main' into loihi_system_refactor

    @mathisrichter
    mathisrichter committed May 26, 2023
    Configuration menu
    Copy the full SHA
    5cd9770 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Finished loihi and slurm docstrings.

    @tim-shea
    tim-shea committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    abdcbd5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into loihi_system_refactor

    @tim-shea
    tim-shea committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    30e6088 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from lava-nc/loihi_system_refactor 

    Finished loihi and slurm docstrings.
    @tim-shea
    tim-shea committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    ac66655 View commit details
    Browse the repository at this point in the history