The Initial version of CLP in CPU backend #707

elvinhajizada · 2023-05-30T22:44:14Z

Issue Number: #706

Objective of pull request:
As a user, I want to be able to use the CLP algorithm in Lava, to learn continually from a stream of data in Loihi chip.

Pull request checklist

Your PR fulfills the following requirements:

Issue created that explains the change and why it's needed
Tests are part of the PR (for bug fixes / features)
Docs reviewed and added / updated if needed (for bug fixes / features)
PR conforms to Coding Conventions
PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
Build tests (pytest) passes locally

Pull request type

Please check your PR type:

What is the current behavior?

We don't have any continual learning algorithm in Lava

What is the new behavior?

This PR is the first step in the full implementation of CLP. With this version of CLP, three base processes are implemented in the CPU backend and have been tested in terms of the following behaviors:

PrototypeLIF process generates the correct bAP signal if it receives a 3rd-factor input
PrototypeLIF process overwrites y1 trace with the value of the received 3rd-factor input, every time such an input is injected
The novelty can be detected from the coincidence between the presence of input and the absence of a subsequent output
Readout process outputs the predicted label
Readout process labels unlabeled winner neurons with user-provided label
Readout process checks the correctness of the predicted label against the user-provided actual label

In addition, several integration tests are written to test if LearningDense -> PrototypeLIF -> NoveltyDetection intengration works properly

Does this introduce a breaking change?

Yes
No

Supplemental information

elvinhajizada · 2023-06-01T11:31:14Z

All check have passes

elvinhajizada · 2023-06-08T14:00:12Z

Integration tests are added

PhilippPlank

Just glanced over it, will review in more detail after some questions.

Why did you call it prototype_lif? It seems like a 3F learning LIF neuron. Also, is this usable in general? If yes, we should not hide it inside clp folder.
What does nsm mean? The process is called Readout, I could not figure out what nsm stands for.
I saw print statements in the PyNoveltyDetectorModel. I assume they are left overs from the development?

elvinhajizada · 2023-06-16T12:02:35Z

Just glanced over it, will review in more detail after some questions.

Why did you call it prototype_lif? It seems like a 3F learning LIF neuron. Also, is this usable in general? If yes, we should not hide it inside clp folder.

What does nsm mean? The process is called Readout, I could not figure out what nsm stands for.

I saw print statements in the PyNoveltyDetectorModel. I assume they are left overs from the development?

@PhilippPlank

Prototype LIF right now looks like a 3F learning LIF, because it is the first, simple of version. In upcoming releases we will add more features to this neuron model that will make it different from LIF (adaptive learning rate, adaptive threshold etc.) So right now it is just setting the interface that will be filled in later releases.
NSM means "Neural State Machines". I planned it as a folder that will host possibly multiple processes. Right now it has only Readout process, because in this release of CLP, we just reading out network prediction. But later, we will need to receive user labels and create supervisory signals to inject into the network. Based on these we will perform both supervised and unsupervised learning. For that purpose we will need other CPU processes as interface between user and network in Loihi 2. So NSM is a general name for bunch of future processes that will control the learning, prediction, labeling states of the system.
Yes, right I will remove those. Thanks for pointing out.

NoveltyDetector

added; lr var removed

src/lava/proc/clp/nsm/process.py

src/lava/proc/clp/prototype_lif/models.py

tests/lava/proc/clp/integration/novelty_det_prototypes.py

tests/lava/proc/clp/nsm/test_nsm.py

drager-intel

Looks good now that all interfaces changes that we discussed have been incorporated. Thanks!

src/lava/proc/clp/novelty_detector/models.py

src/lava/proc/clp/novelty_detector/process.py

This reverts commit bde4fa9.

src/lava/proc/conv/utils.py

Signed-off-by: bamsumit <[email protected]>

* CLP initial commit: PrototypeLIF, NoveltyDetector, Readout procs/tests * small linting fix * Novelty detector upgraded to target next neuron; codacy errors fixed * integration test; small fixes * removed duplicate code in prototypeLIF process; linting fixes * linting fixes * Linting and codacy fixes * remove duplicate test; some more codacy fixes * PrototypeLIF spikes when it recieves a 3rd factor input * a test for PrototypeLIF output spike after 3rd factor input * Allocation & prototype id tracking is abstracted away from NoveltyDetector * Allocator process; Readout proc sends allocation trigger if error * introduce learning rate Var in PrototypeLIF * updated integration tests; full system test included * Linting fixes * Another small lintint fix * PrototypeLIF hard reset capability to enable faster temporal WTA * allocation mechanism changed; proc interfaces changes; dense conns added; lr var removed * small linting fix * small codacy fix * prints removed, spelling mistakes fixed * ignoring one check in an integration test * Revert "small linting fix" This reverts commit bde4fa9. * Fix linting in test_models.py * Test fix in utils.py * Fix test of bug fix in utils.py * Fix utils.py * Implemented individual threadsafe random call Signed-off-by: bamsumit <[email protected]> --------- Signed-off-by: bamsumit <[email protected]> Co-authored-by: PhilippPlank <[email protected]> Co-authored-by: Marcus G K Williams <[email protected]> Co-authored-by: bamsumit <[email protected]>

elvinhajizada added 3 commits May 30, 2023 22:44

CLP initial commit: PrototypeLIF, NoveltyDetector, Readout procs/tests

72ea8f2

Merge branch 'CLP-v1'

549bff4

small linting fix

f24738e

elvinhajizada self-assigned this May 30, 2023

elvinhajizada requested review from bala-git9 and drager-intel May 30, 2023 22:44

elvinhajizada added 1-feature New feature request 0-needs-review For all new issues 2-important/urgent Important and urgent issues labels May 30, 2023

Novelty detector upgraded to target next neuron; codacy errors fixed

be9b147

elvinhajizada added 5 commits June 8, 2023 15:39

integration test; small fixes

f29b056

removed duplicate code in prototypeLIF process; linting fixes

d8bae1f

linting fixes

f109810

Merge branch 'main' of https://github.com/lava-nc/lava

9f1ac3c

Merge branch 'CLP-v1-integration'

d649c43

elvinhajizada requested a review from mathisrichter June 8, 2023 14:00

elvinhajizada added 2 commits June 8, 2023 16:28

Linting and codacy fixes

d15b4cc

remove duplicate test; some more codacy fixes

9a76d9e

PhilippPlank reviewed Jun 14, 2023

View reviewed changes

elvinhajizada added 8 commits June 20, 2023 16:43

PrototypeLIF spikes when it recieves a 3rd factor input

bf68076

a test for PrototypeLIF output spike after 3rd factor input

e3b17b1

Allocation & prototype id tracking is abstracted away from

efe7d71

NoveltyDetector

Allocator process; Readout proc sends allocation trigger if error

7dedbc5

introduce learning rate Var in PrototypeLIF

26160cd

updated integration tests; full system test included

3228094

Merge branch 'main' of https://github.com/lava-nc/lava

3e4a4fc

Linting fixes

e24f412

elvinhajizada added 6 commits July 4, 2023 13:08

Another small lintint fix

0ebfeda

PrototypeLIF hard reset capability to enable faster temporal WTA

611bc47

allocation mechanism changed; proc interfaces changes; dense conns

a5e014e

added; lr var removed

Merge branch 'main' of https://github.com/lava-nc/lava

12b4b4f

small linting fix

bde4fa9

small codacy fix

0113abe

PhilippPlank requested changes Jul 13, 2023

View reviewed changes

prints removed, spelling mistakes fixed

b4cf849

PhilippPlank approved these changes Jul 13, 2023

View reviewed changes

drager-intel approved these changes Jul 14, 2023

View reviewed changes

src/lava/proc/clp/novelty_detector/models.py Outdated Show resolved Hide resolved

src/lava/proc/clp/novelty_detector/process.py Outdated Show resolved Hide resolved

src/lava/proc/clp/novelty_detector/process.py Outdated Show resolved Hide resolved

elvinhajizada and others added 8 commits July 15, 2023 01:27

ignoring one check in an integration test

2ce6359

Revert "small linting fix"

ad67de8

This reverts commit bde4fa9.

Merge branch 'main' into main

858c602

Merge branch 'main' into main

35a8415

Fix linting in test_models.py

44dd75a

Test fix in utils.py

924be71

Fix test of bug fix in utils.py

d4bf01f

Fix utils.py

69a5741

mgkwill requested a review from bamsumit July 17, 2023 20:04

mgkwill reviewed Jul 17, 2023

View reviewed changes

src/lava/proc/conv/utils.py Outdated Show resolved Hide resolved

Implemented individual threadsafe random call

bfbc654

Signed-off-by: bamsumit <[email protected]>

drager-intel merged commit 72fd653 into lava-nc:main Jul 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The Initial version of CLP in CPU backend #707

The Initial version of CLP in CPU backend #707

elvinhajizada commented May 30, 2023 •

edited

Loading

elvinhajizada commented Jun 1, 2023

elvinhajizada commented Jun 8, 2023

PhilippPlank left a comment

elvinhajizada commented Jun 16, 2023

drager-intel left a comment

The Initial version of CLP in CPU backend #707

The Initial version of CLP in CPU backend #707

Conversation

elvinhajizada commented May 30, 2023 • edited Loading

Pull request checklist

Pull request type

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

Supplemental information

elvinhajizada commented Jun 1, 2023

elvinhajizada commented Jun 8, 2023

PhilippPlank left a comment

Choose a reason for hiding this comment

elvinhajizada commented Jun 16, 2023

drager-intel left a comment

Choose a reason for hiding this comment

elvinhajizada commented May 30, 2023 •

edited

Loading