Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing create_runtime unit test. #718

Merged
merged 5 commits into from
Jul 15, 2023
Merged

Conversation

tim-shea
Copy link
Contributor

Issue

Issue Number: #717

Objective

Objective of pull request: Fixing create_runtime unit test.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

  • Bugfix

What is the current behavior?

  • The unit test is failing due to an unimplemented method in a Mock object.

What is the new behavior?

  • The unit test is passing.

Does this introduce a breaking change?

  • No

@tim-shea tim-shea added this to the Lava v0.7.1 milestone Jun 16, 2023
@tim-shea tim-shea self-assigned this Jun 16, 2023
@tim-shea tim-shea linked an issue Jun 16, 2023 that may be closed by this pull request
@tim-shea tim-shea merged commit 9fec649 into main Jul 15, 2023
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* Fixed create_runtime unit test.

* Fixing linter error.

---------

Co-authored-by: PhilippPlank <[email protected]>
Co-authored-by: Marcus G K Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_runtime unit test is failing in test_process
3 participants