Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterator callback function #726

Merged
merged 50 commits into from
Jun 28, 2023
Merged

Iterator callback function #726

merged 50 commits into from
Jun 28, 2023

Conversation

bamsumit
Copy link
Contributor

Issue Number: 725

Objective of pull request:
Implementation of iterator callback function.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • It is not trivially possible with out boilerplate code.

What is the new behavior?

  • It is implemented

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

bamsumit and others added 30 commits March 8, 2022 10:23
Signed-off-by: bamsumit <[email protected]>
@joyeshmishra joyeshmishra self-requested a review June 27, 2023 23:52
src/lava/magma/core/callback_fx.py Outdated Show resolved Hide resolved
src/lava/magma/core/callback_fx.py Outdated Show resolved Hide resolved
@mgkwill mgkwill merged commit 63e4834 into lava-nc:main Jun 28, 2023
6 checks passed
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* update refport unittest to always wait when it writes to port for consistent behavior

Signed-off-by: bamsumit <[email protected]>

* Removed pyproject changes

Signed-off-by: bamsumit <[email protected]>

* Fix to convolution tests. Fixed imcompatible mnist_pretrained for old python versions.

Signed-off-by: bamsumit <[email protected]>

* Missing moudle parent fix

Signed-off-by: bamsumit <[email protected]>

* Added ConvVarModel

* Added iterable callback function

Signed-off-by: bamsumit <[email protected]>

* Fix codacy issues in callback_fx.py

* Fix linting in callback_fx.py

* Fix codacy sig issue in callback_fx.py

---------

Signed-off-by: bamsumit <[email protected]>
Co-authored-by: Joyesh Mishra <[email protected]>
Co-authored-by: Marcus G K Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants