Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tuple to list error #729

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Fix tuple to list error #729

merged 3 commits into from
Jul 18, 2023

Conversation

hexu33
Copy link
Contributor

@hexu33 hexu33 commented Jul 6, 2023

Objective of pull request: Fix AttributeError: 'tuple' object has no attribute 'tolist' in src/lava/proc/conv/utils.py

Pull request checklist

Your PR fulfills the following requirements:

Pull request type

Please check your PR type:

  • Bugfix

What is the current behavior?

  • When using the conv() api in the utils, there will be log error which says,
    AttributeError: 'tuple' object has no attribute 'tolist'

What is the new behavior?

  • conv() in utils.py could be used successfully with no error.

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@hexu33 hexu33 requested a review from bamsumit July 6, 2023 09:29
Copy link
Contributor

@bamsumit bamsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hexu33 looks good. Thank you for the fix. Please also add a description of the existing error. I can see where you are getting errors, but its good to document it.

@mgkwill mgkwill merged commit 185387f into lava-nc:main Jul 18, 2023
6 checks passed
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants