Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization #732

Merged
merged 18 commits into from
Jul 19, 2023
Merged

Serialization #732

merged 18 commits into from
Jul 19, 2023

Conversation

PhilippPlank
Copy link
Contributor

@PhilippPlank PhilippPlank commented Jul 10, 2023

Issue Number: #560

Objective of pull request: To be able to compile a network and reuse this compiled network in cases where the network doesn't change in between compilations or in cases that the network needs to be distributed and packaged with backend hardware. This would accelerate time to execution and enable use of compiled networks in embedded environments.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@PhilippPlank PhilippPlank added the 1-feature New feature request label Jul 10, 2023
@PhilippPlank PhilippPlank self-assigned this Jul 10, 2023
@PhilippPlank PhilippPlank linked an issue Jul 10, 2023 that may be closed by this pull request
@PhilippPlank PhilippPlank marked this pull request as ready for review July 13, 2023 17:06
@epaxon epaxon self-requested a review July 17, 2023 16:29
Copy link
Contributor

@gkarray gkarray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@PhilippPlank PhilippPlank merged commit 87d6a5a into main Jul 19, 2023
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* serialization first try

* first try

* serialization implementation + unittests

* fix linting

* fix bandit

* fix unittest

* fix codacy

* added tutorial

* Update tutorial11_serialization.ipynb

* added notebook to unit tests

* Fixed broken link in tutorial.

---------

Co-authored-by: Mathis Richter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serializable executable
3 participants