Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adding deprecated lava.utils.system. #739

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

tim-shea
Copy link
Contributor

Issue Number: #738

Objective of pull request: Re-add lava.utils.system to fix errors in libs and lava-loihi. Mark as deprecated.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix

What is the current behavior?

What is the new behavior?

  • The module is no longer deleted, just marked as deprecated.

Does this introduce a breaking change?

  • No

@tim-shea tim-shea linked an issue Jul 18, 2023 that may be closed by this pull request
@tim-shea tim-shea self-assigned this Jul 18, 2023
@tim-shea tim-shea added this to the Lava v0.8 milestone Jul 18, 2023
@tim-shea tim-shea merged commit d01c9c3 into main Jul 18, 2023
@tim-shea tim-shea deleted the 738-re-add-lavautilssystem-and-deprecate-functions branch July 18, 2023 18:02
@tim-shea tim-shea restored the 738-re-add-lavautilssystem-and-deprecate-functions branch July 19, 2023 02:58
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* Adding deprecated lava.utils.system.

* Update system.py

* Update system.py

---------

Co-authored-by: PhilippPlank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-add lava.utils.system and deprecate functions.
3 participants