PyInPort: probe() implementation #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awintel
requested review from
mathisrichter,
mgkwill,
awintel and
PhilippPlank
|
I suggest to always include a few more people than just the two minimum required number of reviewers. |
mathisrichter
requested changes
Nov 19, 2021
mathisrichter
requested changes
Nov 22, 2021
PhilippPlank
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Looks good to me for now. At some point we might want to enable InPorts which do not expect data on every csp channel to not block (current behavior, this comes from the fact that previously each InPort had exactly one csp channel), but this is for later I guess.
mathisrichter
approved these changes
Nov 22, 2021
mgkwill
approved these changes
Nov 22, 2021
|
If an InPort has multiple inputs, it expects inputs from all of them. The only way to not block on some input is to receive a flush. |
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* PyInPort probe method + unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
probemethod for PyInPorts.Added :
probemethod for PyInPorts.probemethod forPyInPortVectorDenseonly.