Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pure S4D #868

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Add pure S4D #868

merged 5 commits into from
Jul 16, 2024

Conversation

smm-ncl
Copy link
Contributor

@smm-ncl smm-ncl commented Jul 11, 2024

Objective of pull request: Add pure S4D (without Sigma-Delta Encoding)

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@PhilippPlank PhilippPlank added the 1-feature New feature request label Jul 12, 2024
@smm-ncl smm-ncl requested a review from bamsumit July 15, 2024 09:45
PhilippPlank
PhilippPlank approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@PhilippPlank PhilippPlank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/lava/proc/s4d/models.py Outdated Show resolved Hide resolved
weidel-p
weidel-p approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@weidel-p weidel-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look nice and clean to me.

@smm-ncl smm-ncl merged commit 11c8b02 into main Jul 16, 2024
6 checks passed
@smm-ncl smm-ncl deleted the s4d_update branch July 16, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidel-p weidel-p weidel-p approved these changes

@PhilippPlank PhilippPlank PhilippPlank approved these changes

@bamsumit bamsumit Awaiting requested review from bamsumit

Assignees

@smm-ncl smm-ncl

Labels
1-feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smm-ncl @weidel-p @PhilippPlank