Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up of explicit namespace declaration #98

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

bamsumit
Copy link
Contributor

@bamsumit bamsumit commented Nov 23, 2021

  • explicit namespace declaration cleanup
  • unittests runnable from root level or anywhere in tests/
    python -m unittest

@bamsumit bamsumit linked an issue Nov 23, 2021 that may be closed by this pull request
@bamsumit
Copy link
Contributor Author

Copying PyCharm config instruction from here

  • put the 'src' directories (e.g., lava/src) of all lava repositories into the PYTHONPATH
  • Mark all 'src' directories (e.g., lava/src) as "Sources Root"
  • Mark all 'tests/lava' (NOT tests!) directories (e.g., lava/tests/lava) as "Test Sources Root"

Copy link
Contributor

@mathisrichter mathisrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mathisrichter mathisrichter added this to the Release v0.2.0 milestone Nov 23, 2021
Copy link
Contributor

@mgkwill mgkwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Works from the command line as @bamsumit suggested with python -m unittest and in VS Code using . as root of testing.

Thanks @bamsumit for reworking this change from a clean branch and the testing and effort!

@mgkwill mgkwill merged commit e6ba2d9 into lava-nc:main Nov 23, 2021
@bamsumit bamsumit deleted the clean_init branch November 23, 2021 23:19
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* new init clean from main
* fix build and tests's inits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove legacy __init__.py code
3 participants