Bump oshi version #601
Closed
Bump oshi version #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like there's stats issues on some devices using this oshi version, which makes me think some interfaces changed in between oshi 5.7.4 and 5.8.2. Lavalink.jars using 5.8.2 return None for stats instead of the expected stats list/dict. |
|
I'm gonna close this for now as there seem to be issues with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a user that is using a 64-bit Windows 10 device to host Lavalink and his bot, and he encountered a stats issue/oshi issue when using a Lavalink.jar with oshi 5.7.4, this can be seen in his log at https://gist.githubusercontent.com/Cog-CreatorsBot/93ac8762eee30fed0b661f4f04fd7a3e/raw/3325e473fc269fae52350bd1d7b940fe6470e076/spring_1.log
This issue is reported in oshi/oshi#1710 and resolved with release 5.8.2. I did not bump oshi to 6.0.0 in case there were major breakages or changes with that version, and my user has tested a Lavalink.jar with oshi 5.8.7 on the problematic machine - at the end of the logs I linked there is a Lavalink Spring Boot header where the branch name is
oshi-experimental-fix, and the stats issues are resolved in that log/not present.I have tested this change on an intel Mac with AdoptOpenJDK v 11.0.9 and a 64-bit Linux device running Ubuntu 20.04.3 LTS with Azul Java v 13.0.6 and have not noticed any issues, however I am not knowledgeable in Java and I am not sure if there are any other concerns with bumping this dependency to this version.