Add http timeout configuration for nodes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncte123
requested changes
Feb 11, 2024
| */ | ||
| @JvmOverloads | ||
| fun addNode(name: String, address: URI, password: String, regionFilter: IRegionFilter? = null): LavalinkNode { | ||
| fun addNode(name: String, address: URI, password: String, regionFilter: IRegionFilter? = null, httpTimeout: Long = TIMEOUT_MS): LavalinkNode { |
There was a problem hiding this comment.
With how many parameters there currently are, it may be better to deprecate this method and create a method that accepts a builder instead.
There was a problem hiding this comment.
I was thinking a builder or some sort of node options class that can be extended with all of these
There was a problem hiding this comment.
That sounds good to me. Something like new NodeOptions.Builder().build() -> NodeOptions
|
Added the LavalinkNodeOptions builder, can add some javadocs if you want, but left em out for now because they seem kinda straightforward |
duncte123
requested changes
Feb 14, 2024
src/main/kotlin/dev/arbjerg/lavalink/client/LavalinkNodeOptions.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/dev/arbjerg/lavalink/client/LavalinkNodeOptions.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/dev/arbjerg/lavalink/client/LavalinkNodeOptions.kt
Outdated
Show resolved
Hide resolved
…use new NodeOptions builder
kikkia
force-pushed
the
configure-timeout
branch
from
c15d013
to
3d6e53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently nodes only use the default HTTP timeouts set by OKHTTP, which are:
This PR allows the consumer to set an optional total call timeout. It utilizes the currently unused constant TIMEOUT_MS and changes that to a default of 10sec per request. 10 seconds was chosen to avoid moving the timeout up too much from what it is now, 10 sec to connect, 10 more sec to finish read/write op. I doubt many users have latency > 5s but it avoids someone from getting a regression if they do.