Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to download / re-download vod if it has same name #968

Closed
2 tasks done
MrDummyNL opened this issue Feb 8, 2024 · 3 comments · Fixed by #1085
Closed
2 tasks done

Not able to download / re-download vod if it has same name #968

MrDummyNL opened this issue Feb 8, 2024 · 3 comments · Fixed by #1085
Labels
bug Something isn't working

Comments

@MrDummyNL
Copy link

MrDummyNL commented Feb 8, 2024

Checklist

Edition

Windows GUI Application

Describe your issue here

I have some streams that was stopped midway and restarted again. This result in two vods with exact same name.
But program has one problem: it will ignore next download if it found same name and will not finish the job (it just say its finished -nothing added).
Re-download vod is also problem, it will also just finish it early without generate a vod and text chat file.

Add any related files or extra information here

Here my possible checkpoints:

  • verify the video time (if it found same vod name) so it will know it has another video length.
  • rename the filename with (2) behind as rename.
  • so it will download another vod and make video file without stop it too early with finished.
  • option to force download vod
  • can give you question with [rename] or [overwrite] if it found same vod name file.

Right now i must go to other pc to download another vod. Because program just refuse to download it (again). The download itself is running but it will not finish it correctly.

@MrDummyNL MrDummyNL added the bug Something isn't working label Feb 8, 2024
@ScrubN
Copy link
Collaborator

ScrubN commented Feb 9, 2024

I'm not sure I entirely understand the issue you are describing, however I am not opposed to allowing the user to choose between rename and overwrite. As a temporary solution I added {random_string} as a filename parameter some months ago, but I think its about time I implement a real solution.

@superbonaci
Copy link
Contributor

superbonaci commented Feb 27, 2024

Some streams are cut in several pieces so they are not very long. Basically they all have same title and description, but different ID and were started at different time. Some streams just do this to have each theme they are talking about in a different video, instead of having chapters.

Relying on the title to tell one stream apart from another is not reliable. Same can happen with youtube videos (same exact title):

@superbonaci
Copy link
Contributor

Save the file as ID_Title.mp4 and not Title.mp4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants