Prompt user before overwriting files #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces due to help text ordering
…ing Exists property
ScrubN
added a commit
to ScrubN/TwitchDownloader
that referenced
this pull request
Jun 8, 2024
* Create destination file immediately * Fix potential NRE * Implement FileOverwriteHandler for CLI * Add GetNonCollidingName tests * TwitchDownloaderArgs -> ITwitchDownloaderArgs & rearrange arg interfaces due to help text ordering * Update help text * Create WPF task file overwrite handler * Throw when no output file is returned, refresh FileInfos before checking Exists property * Genericize opening explorer for a given file * Update ___Options output file property to reflect possibly new filename * Add icon * Add translations * Annotate as windows only * Update README * Forgot to add it to the whole CLI * Overwrite -> Collision * Missed a few spots * Update wording * Use warning icon to match file explorer overwrite prompt * Make "remember my choice" wording more clear * Fix missing zh-cn translations
ScrubN
added a commit
to ScrubN/TwitchDownloader
that referenced
this pull request
Jun 8, 2024
* Create destination file immediately * Fix potential NRE * Implement FileOverwriteHandler for CLI * Add GetNonCollidingName tests * TwitchDownloaderArgs -> ITwitchDownloaderArgs & rearrange arg interfaces due to help text ordering * Update help text * Create WPF task file overwrite handler * Throw when no output file is returned, refresh FileInfos before checking Exists property * Genericize opening explorer for a given file * Update ___Options output file property to reflect possibly new filename * Add icon * Add translations * Annotate as windows only * Update README * Forgot to add it to the whole CLI * Overwrite -> Collision * Missed a few spots * Update wording * Use warning icon to match file explorer overwrite prompt * Make "remember my choice" wording more clear * Fix missing zh-cn translations
ScrubN
added a commit
to ScrubN/TwitchDownloader
that referenced
this pull request
Jun 8, 2024
…ernames Fix typo (lay295#1082) Update Simplified Chinese Translation (lay295#1080) Fix TsMerger M3U8 support (lay295#1084) Cleanup (lay295#1086) * Simplify notifying properties * Fix ReadOnlySpanExtensions.UnEscapedIndexOf ArgumentOutOfRangeException args * Fix system emoji vendor missing from exception message * Simplify CacheHandler user prompt code Remove chatupdate compression arg shorthand (-c) (lay295#1087) Fix README Prompt user before overwriting files (lay295#1085) * Create destination file immediately * Fix potential NRE * Implement FileOverwriteHandler for CLI * Add GetNonCollidingName tests * TwitchDownloaderArgs -> ITwitchDownloaderArgs & rearrange arg interfaces due to help text ordering * Update help text * Create WPF task file overwrite handler * Throw when no output file is returned, refresh FileInfos before checking Exists property * Genericize opening explorer for a given file * Update ___Options output file property to reflect possibly new filename * Add icon * Add translations * Annotate as windows only * Update README * Forgot to add it to the whole CLI * Overwrite -> Collision * Missed a few spots * Update wording * Use warning icon to match file explorer overwrite prompt * Make "remember my choice" wording more clear * Fix missing zh-cn translations Add `DEBUG` to WPF title when compiled in debug mode (lay295#1088) Bump nuget packages (lay295#1089) Bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how it looks in the CLI:
This is not present in the regular WPF pages as the file explorer dialog provides a sufficient file overwrite prompt
This is how it looks in the WPF task queue:
Fixes when downloading a clip, vod or chat with the same name. do not overwrite #1081
Fixes Warn when about to overwrite file #997
Fixes Not able to download / re-download vod if it has same name #968
Fixes Feature request: Don't overwrite existing files. #266
Fixes Can't download Clips with the same name #236
Closes Add warning before overwrite file #1034