Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove working directory override in CLI #793

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Remove working directory override in CLI #793

merged 1 commit into from
Aug 17, 2023

Conversation

ScrubN
Copy link
Collaborator

@ScrubN ScrubN commented Aug 16, 2023

@ScrubN
Remove working directory override in CLI
694f43c 
Fixes an issue with relative paths in MacOS
@ScrubN ScrubN merged commit 36773a8 into lay295:master Aug 17, 2023
3 checks passed
@ScrubN ScrubN deleted the macos-path-fix branch August 17, 2023 04:40
@xStrom
Copy link

xStrom commented Sep 27, 2023

For the record this was a problem on Windows 11 too. Overriding the working directory is never a good idea. 👍

@ScrubN
Copy link
Collaborator Author

ScrubN commented Sep 27, 2023

Overriding the working directory is never a good idea.

It did actually solve a very specific problem on Windows, however I have learned both:
A) that it is not worth fixing and users affected should instead change their workflow, and
B) how dotnet single-file publishing actually works,
which is also why I didn't catch it in testing; I was not using a single-file build.

lay295 pushed a commit that referenced this pull request Nov 15, 2023
@ScrubN @Stelminator
@davis-matthew @Teknoist @Deci8BelioS @MEGATREX4
Merge master into kick-support (#880)
7a5711b 
* Triple click template problem (#786)

* Revert "Remove triple click from URL mass downloader text box (#783)"

This reverts commit 559e5d9.

* remove template override?

* Revert "remove template override?"

This reverts commit 499c88d.

* kinda

* better?

* some layout stuff

* cleanup; w/s + center button

* cleanup

* format

* review comments: remove redundant

* visual order

* review feedback: remove template setter on other windows/pages

* review feedback: space between elements

* Account for alternate video highlight url format (#788)

* Account for alternate video highlight url format, increase maintainability of video/clip id regex matching

* Reuse code

* Remove working directory override in CLI (#793)

Fixes an issue with relative paths in MacOS

* Fix WPF crash due to system theme watcher related COMExceptions (#796)

* Catch potential ExternalExceptions when starting WindowsThemeService

* Rename locale key TaskError to TaskErrorButton

* Decorate some windows only functions with SupportedOSPlatformAttribute

* Fix comment

* Do not render sub/highlight backgrounds in transparent renders (#799)

* Compile PayingForward & ChannelPointHighlight colors as SKColors instead of using SKColor.Parse at runtime.

* Do not draw subscribe/misc highlight background if the message background is not opaque enough.

* Fix boolean logic

* WPF Chat Updater Fatal Error Fixes  (#803)

* Do not enable chatupdater buttons until chat json is fully loaded & catch deserialization exceptions.
Fixes a crash when loading large chats

* Catch potential exceptions when setting up chatupdater video/clip info & fix potential for thumbnail image to not update between chats

* Fix potential false positive success from TryGetThumb

* Document exceptions from ChatJson.DeserializeAsync

* Videodownload 99% stop fix (#792)

* Delay ThrottledStream stopwatch creation to first read

* Fix incorrect step for Finalizing Video

* Use CancellationTokenSource timers to cancel DownloadFileAsync after a minimum amount of time

* Bump timeout from 30 seconds to 60

* Add comment explaining CTS trickery

* Increase maxRestartedThreads

* Fix CLI FFmpeg download percentage

* Cleanup GetThirdPartyEmotes

* Change signatures of GetServiceEmoteData & add CancellationTokens

* Add Nullable annotation to Core & WPF

* Rename GetServiceEmoteData -> GetServiceEmotesMetadata

* Whoops, forgot to stage

* Disable nullable ref types for now

* A little bit of cleanup & fix potential url list crash

* Spelling fixes (#814)

* Add support for dark title bars on Windows 10 1809-2004  (#815)

* Support dark title bar on Windows 10 versions between 1809 and 2004 (20H1)

* Decided I prefer having it in this file

* Fix incorrect message.bits_spent for chats between v5 shutdown and 1.51.2 (#817)

* Cleanup

* Include VOD description in video metadata if present (#822)

* Add video description to fetch query

* Serialize video description if applicable

* Sanitize line feeds

* Add video description to chat json files

* Increase "old" directory threshold to 7 days

* Fix some theme related crashes (#831)

* Fix crash when app themes fail to extract

* More appropriate name

* Catch potential FormatExceptions when converting theme color strings to brushes

* Nuget upgrade (#804)

* Bump SkiaSharp to 2.88.5

* Bump HarfBuzzSharp to 2.8.2.5

* Bump Autoupdater.NET to 1.8.4

* Experiment with removing dedicated AlpineLinux SkiaSharp package

* Bump SkiaSharp to 2.88.6 & HarfBuzzSharp to 7.3.0

* Fix duplicate newlines and double spaces in video descriptions

* Quality of life GUI improvements (#833)

* Use URIs so thumbnails are actually cached for reuse

* Add design time DataContext to PageQueue and WindowMassDownload

* Add loading animation to WindowMassDownload

* Fix wrong border color on bandwidth throttle checkbox

* Combine CheckThrottleEnabled Checked functions

* Tabs -> spaces

* Apparently this wasn't entirely necessary

* Increase code readability

* Use ThumbnailService in WindowUrlList & add more video metadata

* Start cleaning up WindowQueueOptions

* Use Nullable.GetValueOrDefault everywhere & general cleanup

* Refactor WindowQueueOptions to be a little bit easier to follow

* Add videos per page selector to mass downloaders (#837)

* Add "videos per page" selector to mass downloader windows

* Update translations

* Remove unused imports

* Update Strings.tr.resx (#836)

Co-authored-by: Scrub <[email protected]>

* update spanish translation (#801)

* Update Strings.es.resx

* Create Readme_es.md

* Rename Readme_es.md to README_es.md

* Update README.md

* Update Strings.es.resx

* Add some NotNullWhen attributes

* Remove explicit copyright year

* Better FFmpeg download progress reporting (#840)

* Add FFmpeg download progress reporting to WPF

* Update translations

* Move expensive console writing off of FFmpeg download thread.

* Bump version

* Fix oversight
I need to enable nullable ref types :/

* Spanish translation update (#842)

* Bump version

* Fix old chats with stringified streamer ids being undeserializable (#843)

* Simplify ChatRootVersion

* Fix chats enqueued by the mass downloaders incorrectly having `.json` file extension

* I promise this is the last time I touch the dark title bar code

* Reuse the theme switcher brush converter

* Fix crash due to negative caret index when computing text box triple click.
Fixes #854

* minor translation additions (#853)

* Update Strings.tr.resx

* Create README_tr.md

* Update README.md

* Update build instructions

* Support highlighting new bit badge notifications (#869)

* Simplify icon generation

* Cleanup

* Add support for bit badge tier notifications

* More simplification

* Even more simplification

* Add Ukrainian Translation (#870)

* Ukrainian Translation

* fix comma

* Fix chat jsons and mp4 metadata lacking any chapters for VODs with 1 chapter and clips (#875)

* Create GetOrGenerateVideoChapters and update GetVideoInfo query

* Make ChatDownloader & VideoDownloader use GetOrGenerateVideoChapters

* Use the same Game object for Video & Clip info responses

* Generate a bogus chapter for clips

* Add context menu to video/clip search mass downloaders (#876)

* Add context menu to mass downloaders

* Update TaskData

* Update translations

* Deserialize chat json files without relying on the file extension (#858)

* Deserialize chat json files without relying on the file extension
This fixes a huge issue with the chat updater that somehow went unnoticed
This also enables deserializing UTF16 BOM and UTF32 BOM files

* Thanks Rider

* Many chat updater fixes (#859)

* Fix incorrect percentages in chat updater

* Make crop lock object not static

* Update video info if possible when updating chats

* Compress chat crop updater temp files with gzip

* Fix ArgumentOutOfRangeException when loading information from chat files with less than 2 comments

* Add functionality to deserialize only the first and last comments

* Fix chapter updating

* Clean curl buffer before returning

* Clean all the buffers, reduce ProgressCopyToAsync overhead, reduce maximum space used when downloading Kick clips

* Change all FileShare.None to FileShare.Read
Could help for debugging lockups

* Fix memory leak

* Forgot to stage

* This is handled by SetHandleAsInvalid

* Fix

---------

Co-authored-by: Christopher Stelma <[email protected]>
Co-authored-by: Matthew Davis <[email protected]>
Co-authored-by: Mahmut Sözen <[email protected]>
Co-authored-by: DeciBelioS <[email protected]>
Co-authored-by: Eugene <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No file when finished? Mac M1.
2 participants
@ScrubN @xStrom