Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-hub README.md updated #64

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

debjani1413
Copy link
Member

Signed-off-by: debjani1413 [email protected]

Description
The failing slack badge in README.md has been fixed.

This PR fixes #62

Notes to reviewers

Checklist

Signed-off-by: debjani1413 <[email protected]>
@aminoxix
Copy link
Contributor

@debjani1413 : Almost done, just need to set pattern as :
[![Slack](https://img.shields.io/badge/[email protected]?logo=slack)](http://slack.layer5.io)

or just use this line, a short edit! 🙂

@debjani1413
Copy link
Member Author

debjani1413 commented Jun 19, 2021

@Amino19 you mean instead of the edit I used I'll use the line mentioned by you right??

@aminoxix
Copy link
Contributor

@debjani1413 : Yes.

Signed-off-by: debjani1413 <[email protected]>
@debjani1413
Copy link
Member Author

@Amino19 I've done the required changes, do review !!

@aminoxix
Copy link
Contributor

aminoxix commented Jun 21, 2021

@debjani1413 : LGTM 🥳

@adithyaakrishna : Pl take this to your end.

@adithyaakrishna adithyaakrishna requested review from adithyaakrishna and removed request for leecalcote June 21, 2021 17:54
@adithyaakrishna
Copy link
Member

@Amino19 Are there any other PRs in other repo similar to this? If so please do mention me there, I'll check and approve. After that I'll ask @Nikhil-Ladha to Merge it :)

@aminoxix
Copy link
Contributor

@adithyaakrishna : Yes sure, we have more issues in other repo similar to this, that needs newcomer to fix!

@Nikhil-Ladha Nikhil-Ladha merged commit a7c97df into layer5io:master Jun 22, 2021
@welcome
Copy link

welcome bot commented Jun 22, 2021

Thanks for your contribution to the Layer5 community! 🎉

Congrats!
        ⭐ Please star the project if you are yet to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[README] Need to fix Slack badge
4 participants