Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: auto bump version for meshery, extensions and cloud #766

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

jerensl
Copy link
Contributor

@jerensl jerensl commented Oct 21, 2024

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the area/ci Continuous integration | Build and release label Oct 21, 2024
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful. And aids in DevEx. Thank you for working on this @jerensl.

Loopholes still exist even with this automation in place. Our foremost need in this area (release safety) is to enhance the "package.json syncer" (a Javascript file from @aabidsofi19 package-synced.js) that exists in meshery-extensions to ensure that if external dependencies fail to reconcile (be the same between Meshery UI and Meshery Extensions that the "Build and Publish" workflow is failed and email is sent (akin to the logic performed for go.mod syncer).

.github/workflows/bump-meshery-version.yml Outdated Show resolved Hide resolved
jerensl and others added 2 commits October 22, 2024 13:45
@jerensl jerensl added pr/do-not-merge PRs not ready to be merged and removed pr/do-not-merge PRs not ready to be merged labels Oct 25, 2024
@leecalcote
Copy link
Member

This is helpful. And aids in DevEx. Thank you for working on this @jerensl.

Loopholes still exist even with this automation in place. Our foremost need in this area (release safety) is to enhance the "package.json syncer" (a Javascript file from @aabidsofi19 package-synced.js) that exists in meshery-extensions to ensure that if external dependencies fail to reconcile (be the same between Meshery UI and Meshery Extensions that the "Build and Publish" workflow is failed and email is sent (akin to the logic performed for go.mod syncer).

@aabidsofi19 @jerensl should we proceed here in acknowledgment that this doesn't completely circumvent a potential issue, but that it is a boon to DevEx?

@jerensl jerensl merged commit 7e3ae4a into layer5io:master Oct 30, 2024
8 checks passed
@jerensl jerensl deleted the ci/auto-bump-version branch October 30, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release
Development

Successfully merging this pull request may close these issues.

2 participants