[slack] Add Accessory interface

lazy-actions · Nov 12, 2019 · 024d5a0 · 024d5a0
1 parent d715676
commit 024d5a0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -10983,8 +10983,8 @@ class Slack extends webhook_1.IncomingWebhook {
         if (status === 'always') {
             throw new Error('"always" cannot be specified with "type" parameter');
         }
-        const color = Slack.accessory[status]['color'];
         const result = Slack.accessory[status]['result'];
+        const color = Slack.accessory[status]['color'];
         const mentionText = this.isMention(mentionCondition, status) ? mention : '';
         let text = `${jobName} ${result}`;
         if (mentionText !== '') {

diff --git a/src/slack.ts b/src/slack.ts
@@ -6,8 +6,19 @@ import {
   IncomingWebhookResult
 } from '@slack/webhook';
 
+interface AccessoryDesign {
+  color: string;
+  result: string;
+}
+
+interface Accessory {
+  failure: AccessoryDesign;
+  success: AccessoryDesign;
+  cancelled: AccessoryDesign;
+}
+
 export class Slack extends IncomingWebhook {
-  static readonly accessory: object = {
+  static readonly accessory: Accessory = {
     failure: {
       color: '#cb2431',
       result: 'Failed'
@@ -94,8 +105,8 @@ export class Slack extends IncomingWebhook {
       throw new Error('"always" cannot be specified with "type" parameter')
     }
 
-    const color: string = Slack.accessory[status]['color'];
     const result: string = Slack.accessory[status]['result'];
+    const color: string = Slack.accessory[status]['color'];
     const mentionText: string = this.isMention(mentionCondition, status) ? mention : '';
     let text: string = `${jobName} ${result}`;