Skip to content

Commit

Permalink
magento#27500 Change annotation for skipped Unit Tests
Browse files Browse the repository at this point in the history
  • Loading branch information
lbajsarowicz committed May 1, 2020
1 parent 07e92d7 commit 258afe6
Show file tree
Hide file tree
Showing 22 changed files with 35 additions and 35 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ public function testRemoveItemByKey($values, $count)
*/
public function testAttributeIdIsInt($values)
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');
$this->resourceHelperMock->expects($this->any())->method('getLoadAttributesSelectGroups')->willReturn([]);
$this->fetchStrategyMock->expects($this->any())->method('fetchAll')->willReturn($values);
$selectMock = $this->coreResourceMock->getConnection()->select();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ public function whiteBlackListProvider()

public function testSetAttributesWhiteList()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$attributes = ['attr1', 'attr2', 'attr3'];
$attrDataFactory = $this->getMockBuilder(AttributeDataFactory::class)
Expand All @@ -335,7 +335,7 @@ public function testSetAttributesWhiteList()

public function testSetAttributesBlackList()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$attributes = ['attr1', 'attr2', 'attr3'];
$attrDataFactory = $this->getMockBuilder(AttributeDataFactory::class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ public function testAddConstraintUnsupportedType()
*/
public function testAddConstraint(array $inputValues, array $expected)
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

foreach ($inputValues as $data) {
$type = $data[0];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ protected function _assertDocBlockData(
array $expectedDocBlock,
DocBlockGenerator $actualDocBlock
) {
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');
// assert plain string data
foreach ($expectedDocBlock as $propertyName => $propertyData) {
if (is_string($propertyData)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ protected function tearDown(): void

public function testConstruct()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

// without parameters
$this->assertAttributeEmpty('_sourceClassName', $this->_model);
Expand Down
8 changes: 4 additions & 4 deletions lib/internal/Magento/Framework/DB/Test/Unit/ProfilerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ protected function setUp(): void

public function testSetHost()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');
$this->_profiler->setHost('localhost');
$this->assertAttributeEquals('localhost', '_host', $this->_profiler);
}

public function testSetType()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');
$this->_profiler->setType('mysql');
$this->assertAttributeEquals('mysql', '_type', $this->_profiler);
}
Expand All @@ -48,7 +48,7 @@ public function testQueryStart()

public function testQueryEnd()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');
$lastQueryId = $this->_profiler->queryStart('SELECT * FROM table');
$endResult = $this->_profiler->queryEnd($lastQueryId);
$this->assertAttributeEquals(null, '_lastQueryId', $this->_profiler);
Expand All @@ -57,7 +57,7 @@ public function testQueryEnd()

public function testQueryEndLast()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');
$this->_profiler->queryStart('SELECT * FROM table');
$endResult = $this->_profiler->queryEndLast();
$this->assertAttributeEquals(null, '_lastQueryId', $this->_profiler);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public function testLoadWithFilter()
*/
public function testSetItemObjectClass($class)
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$this->_model->setItemObjectClass($class);
$this->assertAttributeSame($class, '_itemObjectClass', $this->_model);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ protected function setUp(): void
*/
public function testConstructor(array $inputConfig, array $expectedConfig)
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$object = new Mysql(
$inputConfig,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public function whereCallback($condition)
*/
public function testAppendClassAliasReplace()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$setupMock = $this->getMockForAbstractClass(ModuleDataSetupInterface::class);
$filesystemMock = $this->createMock(Filesystem::class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,15 @@ protected function setUp(): void

public function testConstructor()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$this->assertAttributeEquals($this->_defaultDriverPrefix, '_defaultDriverPrefix', $this->_factory);
$this->assertAttributeEquals($this->_defaultDriverType, '_defaultDriverType', $this->_factory);
}

public function testDefaultConstructor()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$factory = new Factory();
$this->assertAttributeNotEmpty('_defaultDriverPrefix', $factory);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class CsvfileTest extends TestCase
*/
public function testConstructor($config, $expectedFilePath, $expectedDelimiter, $expectedEnclosure)
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$output = new Csvfile($config);
$this->assertAttributeEquals($expectedFilePath, '_filePath', $output);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,15 @@ protected function setUp(): void

public function testConstructor()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$this->assertAttributeEquals($this->_defaultOutputPrefix, '_defaultOutputPrefix', $this->_factory);
$this->assertAttributeEquals($this->_defaultOutputType, '_defaultOutputType', $this->_factory);
}

public function testDefaultConstructor()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$factory = new Factory();
$this->assertAttributeNotEmpty('_defaultOutputPrefix', $factory);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ protected function setUp(): void
*/
public function testSetFilterPattern()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$this->assertAttributeEmpty('_filterPattern', $this->_output);
$filterPattern = '/test/';
Expand All @@ -45,7 +45,7 @@ public function testSetFilterPattern()
*/
public function testSetThreshold()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$thresholdKey = Stat::TIME;
$this->_output->setThreshold($thresholdKey, 100);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ public function testStopWithInvalidTimer()
*/
public function testClear()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$this->_stat->start('timer1', 1, 20, 10);
$this->_stat->start('timer2', 2, 20, 10);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ protected function tearDown(): void
*/
public function testDefaultConstructor()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$driver = new Standard();
$this->assertAttributeInstanceOf(Stat::class, '_stat', $driver);
Expand Down Expand Up @@ -99,7 +99,7 @@ public function testStop()
*/
public function testInitOutputs()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$outputFactory = $this->createMock(Factory::class);
$config = [
Expand Down
10 changes: 5 additions & 5 deletions lib/internal/Magento/Framework/Test/Unit/ProfilerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public function testDisable()

public function testSetDefaultTags()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$expected = ['some_key' => 'some_value'];
Profiler::setDefaultTags($expected);
Expand All @@ -43,7 +43,7 @@ public function testSetDefaultTags()

public function testAddTagFilter()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

Profiler::addTagFilter('tag1', 'value_1.1');
Profiler::addTagFilter('tag2', 'value_2.1');
Expand All @@ -56,7 +56,7 @@ public function testAddTagFilter()

public function testAdd()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$mock = $this->_getDriverMock();
Profiler::add($mock);
Expand Down Expand Up @@ -223,7 +223,7 @@ public function testClearException()

public function testResetProfiler()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$driver = $this->_getDriverMock();
$driver->expects($this->once())->method('clear')->with(null);
Expand Down Expand Up @@ -295,7 +295,7 @@ public function passedFilterDataProvider()

public function testApplyConfig()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$mockDriver = $this->createMock(DriverInterface::class);
$driverConfig = ['type' => 'foo'];
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/Magento/Framework/Test/Unit/ValidatorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public function isValidDataProvider()
*/
public function testAddValidator()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');
$fooValidator = new IsTrue();
$classConstraint = new Constraint($fooValidator, 'id');
$propertyValidator = new Property($classConstraint, 'name', 'id');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ function ($validator) {
*/
public function testAddConfiguration($constraints, $alias, $configuration, $expected)
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

/** @var \Magento\Framework\Validator\Builder $builder */
$builder = $this->_objectManager->getObject(
Expand All @@ -208,7 +208,7 @@ public function testAddConfiguration($constraints, $alias, $configuration, $expe
*/
public function testAddConfigurations($constraints, $alias, $configuration, $expected)
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

/** @var \Magento\Framework\Validator\Builder $builder */
$builder = $this->_objectManager->getObject(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ public function getValidationRulesDataProvider()
*/
public function testBuilderConfiguration()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

$this->getMockBuilder(Builder::class)
->disableOriginalConstructor()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public function getTestValue()
*/
public function testSetArguments($value, $expectedValue)
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');
$option = new Callback(function () {
});
$option->setArguments($value);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public function testDeserialize()

public function testHandleErrors()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');

/** Add error message */
$firstErrorMessage = "No document type declaration. ";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class StdoTest extends TestCase
{
public function testThatHandlerIsRight()
{
$this->markTestSkipped('Testing protected / private methods / properties');
$this->markTestSkipped('Skipped in #27500 due to testing protected/private methods and properties');
$writer = new Stdo();
$this->assertAttributeEquals(STDOUT, '_fileHandler', $writer);
}
Expand Down

0 comments on commit 258afe6

Please sign in to comment.