Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnergyPlus does not report QLat_flow and QPeo_flow #2602

Closed
mwetter opened this issue Sep 7, 2021 · 8 comments · Fixed by #2696
Closed

EnergyPlus does not report QLat_flow and QPeo_flow #2602

mwetter opened this issue Sep 7, 2021 · 8 comments · Fixed by #2696
Assignees
Labels
bug spawn Development for Spawn of EnergyPlus
Milestone

Comments

@mwetter
Copy link
Member

mwetter commented Sep 7, 2021

EnergyPlus does not output the values for the latent heat gains of the zone and the heat emitted by people. See https://lbl-srg.github.io/soep/softwareArchitecture.html#coupling-of-the-envelope-model for the specification.

To reproduce, simulate

Advanced.StoreProtectedVariables = true;
simulateModel("Buildings.ThermalZones.EnergyPlus.Examples.SingleFamilyHouse.Unconditioned", stopTime=432000, method="Cvode", tolerance=1e-06, resultFile="Unconditioned");

and look at QPeo_flow and QLat_flow.

This was tested on the master branch (commit 558ac77).

@mwetter mwetter added bug spawn Development for Spawn of EnergyPlus labels Sep 7, 2021
@mwetter mwetter modified the milestones: Release 9.0, Release 8.0.1 Sep 7, 2021
kbenne added a commit to NREL/Spawn that referenced this issue Oct 11, 2021
kbenne added a commit to NREL/Spawn that referenced this issue Oct 13, 2021
kbenne added a commit to NREL/Spawn that referenced this issue Oct 13, 2021
@kbenne
Copy link
Contributor

kbenne commented Oct 13, 2021

@mwetter To address this issue, I tagged v0.1.2. The contents of this tag are v0.1.1 plus...

  1. The QLat_flow fix
  2. QPeo_flow fix
  3. Version bump from v0.1.1 to v0.1.2

NREL/Spawn@v0.1.1...v0.1.2

I will also merge these commits into the main develop branch. CI Builds are still running at the moment.

@mwetter
Copy link
Member Author

mwetter commented Oct 19, 2021

@kbenne : The CI tests fail on https://gitlab.com/kylebenne/spawn/-/pipelines?scope=all&page=1 Can you please let me know when this is ready to implement (with EnergyPlus 9.5 so we can patch Buildings 8.0.0)

@kbenne
Copy link
Contributor

kbenne commented Oct 19, 2021

yes. I've been working on it. Couple of issues im addressing. 1. Back in version 0.1.0 we used a service called bintray to manage third party depndencies which is no longer available, so I had to back port the replacement. 2. I had to reimage the Mac CI machine. The builds are rerunning at this moment, so we'll see.

@mwetter
Copy link
Member Author

mwetter commented Oct 19, 2021

Thanks

@mwetter
Copy link
Member Author

mwetter commented Oct 21, 2021

@kbenne : The results are not plausible. This input file has 3 people, and QPeo_flow is about 240 kW. See results below.

simulateModel("Buildings.ThermalZones.EnergyPlus.Examples.SingleFamilyHouse.Unconditioned", stopTime=432000, method="Cvode", tolerance=1e-06, resultFile="Unconditioned");

image

@kbenne
Copy link
Contributor

kbenne commented Oct 21, 2021

yeah those people are putting off some heat! big lunch?

@kbenne
Copy link
Contributor

kbenne commented Oct 21, 2021

I'll take a look. the latent flow looks reasonable to me. Obviously not the people.

@kbenne
Copy link
Contributor

kbenne commented Oct 22, 2021

@mwetter I posted a new build with correction. https://gitlab.com/kylebenne/spawn/-/pipelines/393199586

The amateur here gave you energy instead of power. That is embarrassing. I tightened up the unit test a little. You might take a look. https://github.com/NREL/Spawn/blob/894d972d4160a7e1b3e9ea0f24057156ce1be133/test/test_single_family_house.cpp#L155

mwetter added a commit that referenced this issue Oct 26, 2021
* Updated binaries for #2602. This fixes QLat_flow and QPeo_flow

* Updated documentation and protected blocks
mwetter added a commit that referenced this issue Oct 26, 2021
* Updated binaries for #2602. This fixes QLat_flow and QPeo_flow
kbenne added a commit to NREL/Spawn that referenced this issue Oct 29, 2021
kbenne added a commit to NREL/Spawn that referenced this issue Oct 29, 2021
kbenne added a commit to NREL/Spawn that referenced this issue Oct 29, 2021
This variable was reporting energy, not power like it was supposed to.

ref lbl-srg/modelica-buildings#2602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug spawn Development for Spawn of EnergyPlus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants