Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CDL.*Switch blocks #2650

Closed
mwetter opened this issue Oct 4, 2021 · 0 comments · Fixed by #2654
Closed

Rename CDL.*Switch blocks #2650

mwetter opened this issue Oct 4, 2021 · 0 comments · Fixed by #2654
Assignees
@JayHuLBL
Labels
OpenBuildingControl
Milestone
Release 9.0

Comments

@mwetter
Copy link
Member

mwetter commented Oct 4, 2021

Currently, in OBC.CDL, there is
Logical.IntegerSwitch,
Logical.LogicalSwitch and
Logical.Switch
which is an inconsistent naming. Because other blocks such as Add are present as Continuous.Add and Integer.Add, these blocks should be renamed to

CDL.Integer.Switch,
CDL.Logical.Switch and
CDL.Continuous.Switch.

Also, the conversion script needs to be updated for this change.
@mwetter mwetter added this to the Release 9.0 milestone Oct 4, 2021
@mwetter mwetter changed the title Renamed CDL.*Switch blocks Rename CDL.*Switch blocks Oct 4, 2021
@JayHuLBL JayHuLBL mentioned this issue Oct 5, 2021
Merged
4 tasks
mwetter pushed a commit that referenced this issue Oct 5, 2021
@JayHuLBL
Rename CDL.*Switch blocks (#2654)
b65beff 
* changed block names for #2650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JayHuLBL JayHuLBL

Labels
OpenBuildingControl
Projects
None yet
Milestone
Release 9.0
Development

Successfully merging a pull request may close this issue.

Rename CDL.*Switch blocks lbl-srg/modelica-buildings
2 participants
@mwetter @JayHuLBL