Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformulate BoundaryConditions.GroundTemperature.BaseClasses.surfaceTemperature #2698

Closed
mwetter opened this issue Oct 26, 2021 · 0 comments
Closed

Reformulate BoundaryConditions.GroundTemperature.BaseClasses.surfaceTemperature #2698

mwetter opened this issue Oct 26, 2021 · 0 comments
Assignees
@mwetter

Comments

@mwetter
Copy link
Member

mwetter commented Oct 26, 2021

The buried pipe models do not translate in OpenModelica. The translation message is

Buildings/BoundaryConditions/GroundTemperature/BaseClasses/surfaceTemperature.mo:39:3-42:69:writable] Error: 
Function argument TSurMea=sum(TSurDayMea) / CAST(Real, Year) in call to 
Buildings.BoundaryConditions.GroundTemperature.ClimaticConstants.Generic 
has variability discrete which is not a parameter expression.

The issue is related to parameter assignments via functions that return a record. This issue is to refactor the function so it returns a tuple of values rather than a record.
@mwetter mwetter self-assigned this Oct 26, 2021
mwetter added a commit that referenced this issue Oct 26, 2021
@mwetter
Reformulated function to return tuple rather than record
84bfda1 
This is for #2698
@mwetter mwetter mentioned this issue Oct 26, 2021
Merged
mwetter added a commit that referenced this issue Oct 29, 2021
@mwetter @bravache
Reformulated function to return tuple rather than record (#2699)
8b5ba4f 
* Reformulated function to return tuple rather than record

This is for #2698

* declare function parameters

* Declared function parameters to avoid division by zero in Dymola

Co-authored-by: Baptiste Ravache <[email protected]>
@mwetter mwetter closed this as completed Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mwetter