Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOM are detected by CI but do not raise an error #3028

Closed
mwetter opened this issue May 21, 2022 · 0 comments · Fixed by #3029
Closed

BOM are detected by CI but do not raise an error #3028

mwetter opened this issue May 21, 2022 · 0 comments · Fixed by #3029
Assignees

Comments

@mwetter
Copy link
Member

mwetter commented May 21, 2022

UTF-8 BOM are detected by the CI test, but no error is thrown.

See test log of master@ef6ffe5: This was before Jianjun removed BOM. The BOM check found it in ./Fluid/Storage/Ice/Tank.mo, but the test passed regardless.
After Jianjun removed BOM in master@99d2bdc: The test no longer returned the file name.

This issue is to correct the CI test.

@hcasperfu : Thanks for reporting, I will update the test

@mwetter mwetter self-assigned this May 21, 2022
mwetter added a commit that referenced this issue May 21, 2022
mwetter added a commit that referenced this issue May 21, 2022
mwetter added a commit that referenced this issue May 21, 2022
mwetter added a commit that referenced this issue May 24, 2022
* Updated test for BOM

This is for #3028
mwetter added a commit that referenced this issue May 24, 2022
* Updated test for BOM

This is for #3028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant