Merge new weather data implementation from IBPSA #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rfiles and issue1494_plugflowpipe_singleoutlet
…atherfiles BESTEST and other results only changed slightly. Some examples such as Buildings.HeatTransfer.Windows.BaseClasses.Examples.WindowRadiation changed significantly because the model used the latitude as a parameter which was set to a different value than the location of the weather data file has. With this code change, the latitude from the weather data file is used
Dymola assumes a signal of 0 if it is not set on the weather data bus, whereas OCT issues a translation error
mwetter
deleted the
IBPSASync_issue1477_diffuseRadiation_AND_issue1478_BESTEST_weatherfiles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
latparameter from models such as the envelope