Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump delta notifier for better error reporting #174

Merged
merged 0 commits into from
Feb 21, 2024

Conversation

nvdk
Copy link
Member

@nvdk nvdk commented Dec 14, 2023

Overview

bump delta notifier for better error reporting and (to be proven) slightly faster delta delivery.

connected issues and PRs:

None

Setup

docker-compose up -d

How to test/reproduce

Start app, do some changes check if delta's are sent. Creating a file via the file service would be a good test case

Challenges/uncertainties

It's already in use in some production apps, so I don't expect any issues. Some errors might come to light because they're now actually logged in the containers' log.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

@abeforgit abeforgit merged this pull request into master Feb 21, 2024
@abeforgit abeforgit deleted the chore/bump-delta-notifier branch February 21, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants