Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tombstone resources for deletions in LDES feed #210

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

abeforgit
Copy link
Member

@abeforgit abeforgit commented Oct 30, 2024

  • fix(ldes): handle Tombstone types
  • fix(ldes): cleaner method of selecting tombstones

Overview

the LDES feed uses the Tombstone type to indicate deleted items.
It swaps out the subject's type for Tombstone, and adds the old type under the
formerType predicate. It's a clean mechanism, we just have to make sure to
capture the tombstone types to overwrite the old data.

connected issues and PRs:

Setup

this will of course only work on new ldes data, so you have to reset your ldes
state for it to pick up on all the deletions

here's how to reset your ldes state without nuking your db:

PREFIX ext: <http://mu.semte.ch/vocabularies/ext/>
DELETE {
  GRAPH ?g {
    ?s ?p ?v.
  }
} WHERE { 
  GRAPH ?g { 
    ?s a ext:LDESClientState; 
        ?p ?v. 
  } 
}

this will cause the client to do a full ingest on the next tick, so make sure your BYPASS_MU_AUTH is set accordingly

How to test/reproduce

Challenges/uncertainties

Checks PR readiness

  • changelog
  • no new deprecations

@abeforgit abeforgit changed the title fix/handle ldes deletes Handle tombstone resources for deletions in LDES feed Oct 30, 2024
Copy link
Contributor

@piemonkey piemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work for me once I've actually let ldes-client catch up.

@abeforgit abeforgit merged commit 2d07589 into master Oct 30, 2024
@abeforgit abeforgit deleted the fix/handle-ldes-deletes branch October 30, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants