Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ldes-client): ensure type of person is correctly consumed #212

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Nov 12, 2024

Overview

This PR ensures that the type of a person resource (http://www.w3.org/ns/person#Person) is also correctly consumed and inserted into the public graph.

connected issues and PRs:

Discovered while working on GN-5217

Setup

  • Ensure you have the ldes-client setup correctly.
  • Set EMBER_GN_FEATURE_MANDATEE_TABLE_EDITOR to true to easily test/add mandatee tables.

How to test/reproduce

  • Start the stack, ensure the ldes-client service has finished consuming
  • Open the frontend, and login as an OCMW
  • Logging in with the corresponding user in LMB, add a 'non-elected'/custom person to the BCSD council
  • The ldes-client should consume the new person and mandatee
    • The public information should be consumed into the public graph
    • The private info into a private graph (note: it will be consumed into the private graph of the municipality, not the OCMW, this seems to be an error/issue on the side of LMB, but is not actually an issue for us as we only need their public data)
  • When syncing the IV containing a mandatee table (e.g. IVRMW2-LMB-2-kandidaat-leden), the custom person should show up.

Challenges/uncertainties

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Nov 14, 2024
@elpoelma elpoelma self-assigned this Nov 14, 2024
@elpoelma elpoelma marked this pull request as ready for review November 14, 2024 09:07
@abeforgit abeforgit merged commit 12da430 into master Nov 14, 2024
@abeforgit abeforgit deleted the fix/ldes-client-person-type branch November 14, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants