-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #323 from lblod/breaking/component-helper-removal
Drop usage of component-helper
- Loading branch information
Showing
5 changed files
with
94 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
--- | ||
'@lblod/ember-rdfa-editor-lblod-plugins': major | ||
--- | ||
|
||
Remove usage of `component` helper in preparation of embroider-compatibility. | ||
|
||
This removal also causes a change in the variable-plugin insert-component API, the insert-components now need to be passed directly (instead of their path). | ||
|
||
Before: | ||
|
||
```typescript | ||
get variableTypes(): VariableConfig[] { | ||
return [ | ||
{ | ||
label: 'text', | ||
component: { | ||
path: 'variable-plugin/text/insert', | ||
}, | ||
}, | ||
{ | ||
label: 'location', | ||
component: { | ||
path: 'variable-plugin/location/insert', | ||
options: { | ||
endpoint: 'https://dev.roadsigns.lblod.info/sparql', | ||
}, | ||
}, | ||
}, | ||
]; | ||
} | ||
``` | ||
|
||
After: | ||
|
||
```typescript | ||
import TextVariableInsertComponent from '@lblod/ember-rdfa-editor-lblod-plugins/components/variable-plugin/text/insert'; | ||
import LocationInsertComponent from '@lblod/ember-rdfa-editor-lblod-plugins/components/variable-plugin/location/insert'; | ||
... | ||
get variableTypes() { | ||
return [ | ||
{ | ||
label: 'text', | ||
component: TextVariableInsertComponent, | ||
}, | ||
{ | ||
label: 'location', | ||
component: LocationInsertComponent, | ||
options: { | ||
endpoint: 'https://dev.roadsigns.lblod.info/sparql', | ||
}, | ||
}, | ||
]; | ||
} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters