Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4544: Always get decision title from public decisions #311

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

dkozickis
Copy link
Contributor

Overview

Always get decision title from public decisions.
There was an issue where ?decisionTitle was not always fetched by public decisions query correctly. This fixes that 🙏

connected issues and PRs:

Setup

  1. Checkout
  2. npm run start

How to test/reproduce

  1. Go to Besluit Sample
  2. Try to insert reference
  3. Change filter to the one depicted on the image
  4. Observe that results are rendered correctly

image

Challenges/uncertainties

Instead of using ?decisionTitle in both OPTIONAL fragment I've used different names based on where decisionTitle is coming from and then BOUND ( COALESCE, works a charm

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint
  • no new deprecations

@dkozickis dkozickis requested review from piemonkey, abeforgit, elpoelma and aatauil and removed request for aatauil September 29, 2023 08:15
@piemonkey
Copy link
Collaborator

The testing steps work fine, but they also seem to work on master, so I can't verify whether it has worked. I followed the steps and used the same filter as in the screenshot.

Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I did manage to reproduce the original issue on master

@dkozickis dkozickis merged commit 6cfa740 into master Oct 2, 2023
3 checks passed
@dkozickis dkozickis deleted the GN-4544 branch October 2, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants