GN-4524: date variable - fix config option to disable custom format #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piemonkey
approved these changes
Oct 6, 2023
abeforgit
deleted the
GN-4524-editor-plugins-rd-fa-date-always-allows-custom-format-even-if-allow-custom-format-is-false
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The config and readme already included the option
allowCustomFormat, but this did not do anything. This PR fixes so that ifallowCustomFormatis set tofalse, a custom format can't be used.connected issues and PRs:
https://binnenland.atlassian.net/browse/GN-4524
How to test/reproduce
Change the config (depending on your test).
If
allowCustomFormatis set to false, the radio buttoncustom formatshould be disabled.If the config option is missing (or set to true), the radio button should work.
In all older documents the date variable should always allow custom format (e.g. export and import some html of an older editor version, like the dev version)
Challenges/uncertainties
The default for this is set to true by default everywhere. This follows how it was before: regardless of the config option, custom formats were allowed. This makes this a non-breaking change.
the customAllowed boolean is added to the dataset instead of as rdfa, because this info for specifically for the editor UI and not meant as data to be published.