Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4538: Show empty search result when there are no streets #317

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

dkozickis
Copy link
Contributor

Overview

GN-4538: Show empty search result when there are no streets

Issue was caused by straatnaam field not existing in the response when there are no streets found.

connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4538

Setup

  1. Checkout
  2. npm run start

How to test/reproduce

  1. Insert address
  2. Try to search for an existing street e.g. Drongenstationstraat in Gent
  3. Select the result
  4. Now search for non-existing street
  5. Observe that you see "no streets found" notification instead of the results of previous search

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma merged commit 1f02c94 into master Oct 9, 2023
3 checks passed
@elpoelma elpoelma deleted the GN-4538 branch October 9, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants