Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure embroider-optimized compatibility #332

Merged
merged 10 commits into from
Oct 20, 2023

Conversation

elpoelma
Copy link
Collaborator

@elpoelma elpoelma commented Oct 20, 2023

Overview

This PR includes some changes to ensure embroider-optimized compatibility:

  • Some changes to the webpack configuration and exporting a webpack config object for host apps in webpack-config.js'
  • Update ember-resolver to 11.0.1
  • Addition of @ember/string as a dev- and peer-dependency. (see https://deprecations.emberjs.com/v4.x/#toc_ember-string-add-package)
  • Include explicit .js extension for process/brower.js webpack plugin to ensure esmodule compatibility
  • Explicitly import ember-velcro component to workaround embroider issue. (see lblod/ember-rdfa-editor@c8e8de8)

Additionally this PR includes the following changes:

  • Addition of ember-power-select as a peerdependency. It specifies the 6.x and 7.x ranges.

How to test/reproduce

  • Run the embroider-optimized scenario (ember try:one embroider-optimized) and ensure no errors occur
  • Ensure that the dummy application still works as expected.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint

@elpoelma elpoelma changed the base branch from master to feature/support-embroider-builds October 20, 2023 10:57
Base automatically changed from feature/support-embroider-builds to master October 20, 2023 10:57
@elpoelma elpoelma force-pushed the feature/embroider-safe-compat branch from 992b5a9 to 55b22cc Compare October 20, 2023 11:18
@elpoelma
Copy link
Collaborator Author

Update: the embroider-safe scenario now succeeds without errors.

@elpoelma
Copy link
Collaborator Author

elpoelma commented Oct 20, 2023

Once lblod/ember-rdfa-editor#995 is merged, embroider-optimized will also succeed. I changed the base to that PR as it is need for embroider-optimized

@elpoelma elpoelma changed the title Ensure embroider-safe compatibility Ensure embroider-optimized compatibility Oct 20, 2023
@elpoelma elpoelma force-pushed the feature/embroider-safe-compat branch from 47220b7 to b6e2d7b Compare October 20, 2023 12:13
@elpoelma elpoelma changed the base branch from master to fix/appuniversum-2.16-compatibility October 20, 2023 12:14
@elpoelma elpoelma marked this pull request as ready for review October 20, 2023 12:15
@elpoelma
Copy link
Collaborator Author

@piemonkey @abeforgit I don't think this PR is really breaking?

Base automatically changed from fix/appuniversum-2.16-compatibility to master October 20, 2023 15:52
@abeforgit abeforgit merged commit cf7082f into master Oct 20, 2023
2 checks passed
@abeforgit abeforgit deleted the feature/embroider-safe-compat branch October 20, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants