-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure embroider-optimized compatibility #332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with ember-appuniversum 2.16.0
elpoelma
changed the base branch from
master
to
feature/support-embroider-builds
October 20, 2023 10:57
elpoelma
force-pushed
the
feature/embroider-safe-compat
branch
from
October 20, 2023 11:18
992b5a9
to
55b22cc
Compare
Update: the |
Once lblod/ember-rdfa-editor#995 is merged, |
elpoelma
changed the title
Ensure embroider-safe compatibility
Ensure embroider-optimized compatibility
Oct 20, 2023
…sion to process/browser webpack plugin
elpoelma
force-pushed
the
feature/embroider-safe-compat
branch
from
October 20, 2023 12:13
47220b7
to
b6e2d7b
Compare
elpoelma
changed the base branch from
master
to
fix/appuniversum-2.16-compatibility
October 20, 2023 12:14
@piemonkey @abeforgit I don't think this PR is really breaking? |
Base automatically changed from
fix/appuniversum-2.16-compatibility
to
master
October 20, 2023 15:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR includes some changes to ensure
embroider-optimized
compatibility:webpack-config.js
'ember-resolver
to 11.0.1@ember/string
as a dev- and peer-dependency. (see https://deprecations.emberjs.com/v4.x/#toc_ember-string-add-package).js
extension forprocess/brower.js
webpack plugin to ensure esmodule compatibilityAdditionally this PR includes the following changes:
ember-power-select
as a peerdependency. It specifies the6.x
and7.x
ranges.How to test/reproduce
embroider-optimized
scenario (ember try:one embroider-optimized
) and ensure no errors occurChecks PR readiness